Naming refactor#4
Open
fnunnari wants to merge 10 commits into
Open
Conversation
Renamed methods to better match their role. Added comments. Renamed variables. Added many asserts as self-documenting directives. Moved fixed names as top code constants.
Move scene initialization out of the Glue class. Some other comments and renaming.
…lender file contains not only an armature, but also the head mesh.
Also fixed some logging messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of renaming and comments before actually implementing the face animation.
Could go alone in the main branch without breaking any retro compatibility.