Support aria-controls for buttons that toggle non-panel/popup UI#409
Merged
Conversation
Adds an `ariaControls` button-config prop (string or context-fn) that sets aria-controls directly, for buttons that expand a plugin-owned control rather than a panel or popup menu. Also scopes plugin dispatch to the originating plugin id so it routes correctly through the combined reducer when called from evaluated props. Extracted from the search-refactor branch so button+control consumers don't need to depend on that branch landing first.
|
markfee
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
ariaControlsbutton-config prop (string or function) that sets aria-controls directly, for buttons that expand a plugin-owned control rather than a panel or popup menu. Also scopes plugin dispatch to the originating plugin id so it routes correctly through the combined reducer when called from evaluated props.Extracted from the search-refactor branch so button+control consumers don't need to depend on that branch landing first.