Skip to content

IM-399 added feature layer renderer to esri#408

Merged
markfee merged 7 commits into
IM-360-reviewedfrom
IM-399
Jul 17, 2026
Merged

IM-399 added feature layer renderer to esri#408
markfee merged 7 commits into
IM-360-reviewedfrom
IM-399

IM-399 Sonar issue handled

a334730
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 17, 2026 in 46s

Quality Gate failed

Failed conditions
78.0% Coverage on New Code (required ≥ 90%)
3 New Major Issues (required ≤ 0)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 68 in plugins/datasets/src/registry/dataset.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDtuHyyQDcGgrDis&open=AZ9vBDtuHyyQDcGgrDis&pullRequest=408

Check warning on line 233 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDvYHyyQDcGgrDi1&open=AZ9vBDvYHyyQDcGgrDi1&pullRequest=408

Check warning on line 227 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDvYHyyQDcGgrDi0&open=AZ9vBDvYHyyQDcGgrDi0&pullRequest=408

Check warning on line 59 in src/scss/tools/_border-focus.scss

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Missing scoping root 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDr1HyyQDcGgrDiq&open=AZ9vBDr1HyyQDcGgrDiq&pullRequest=408

Check warning on line 73 in plugins/datasets/src/registry/dataset.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDtuHyyQDcGgrDit&open=AZ9vBDtuHyyQDcGgrDit&pullRequest=408

Check failure on line 81 in plugins/datasets/src/adapters/esri/esriLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `return value` over `return Promise.resolve(value)`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vDz85_DKIVWEQltku&open=AZ9vDz85_DKIVWEQltku&pullRequest=408

Check warning on line 161 in plugins/datasets/src/registry/dataset.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use null instead. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDtuHyyQDcGgrDiu&open=AZ9vBDtuHyyQDcGgrDiu&pullRequest=408

Check warning on line 37 in plugins/datasets/src/adapters/esri/registry/esriDataset.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `structuredClone(…)` over `JSON.parse(JSON.stringify(…))` to create a deep clone. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDv6HyyQDcGgrDi2&open=AZ9vBDv6HyyQDcGgrDi2&pullRequest=408

Check warning on line 17 in plugins/datasets/src/fetch/createDynamicSource.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 121 lines, which is greater than the 75 lines authorized. Split it into smaller functions. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDwhHyyQDcGgrDi4&open=AZ9vBDwhHyyQDcGgrDi4&pullRequest=408

Check warning on line 168 in plugins/datasets/src/adapters/maplibre/maplibreLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Prefer `.some(…)` over non-zero length check from `.filter(…)`. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDuzHyyQDcGgrDiy&open=AZ9vBDuzHyyQDcGgrDiy&pullRequest=408

Check warning on line 128 in plugins/datasets/src/registry/datasetRegistry.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDuNHyyQDcGgrDiw&open=AZ9vBDuNHyyQDcGgrDiw&pullRequest=408

Check warning on line 50 in plugins/datasets/src/initialise/initialiseDatasets.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDtOHyyQDcGgrDir&open=AZ9vBDtOHyyQDcGgrDir&pullRequest=408

Check warning on line 106 in plugins/datasets/src/adapters/maplibre/maplibreLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDuzHyyQDcGgrDix&open=AZ9vBDuzHyyQDcGgrDix&pullRequest=408

Check warning on line 7 in plugins/datasets/src/registry/globalDataset.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDuAHyyQDcGgrDiv&open=AZ9vBDuAHyyQDcGgrDiv&pullRequest=408

Check warning on line 11 in plugins/datasets/src/adapters/loadLayerAdapter.js

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=DEFRA_interactive-map&issues=AZ9vBDwFHyyQDcGgrDi3&open=AZ9vBDwFHyyQDcGgrDi3&pullRequest=408
View more details on SonarQubeCloud