Retire self-generated id↔label validator sha256 pin (Phase 2 step 2d)#179
Merged
Conversation
The `vendored-sync` CI job (scripts/check_vendored_sync.sh, shared-reference diff against CultureBotAI/CultureMech@<.vendored_canon_ref>, merged in #176) has replaced the self-generated sha256 pin, which could only compare a copy to a hash from the same repo — so all four repos could pass verify-validator-pin while diverged. Remove the redundant second mechanism: - delete verify-/refresh-validator-pin recipes + VENDORED_IDLABEL_FILES manifest - delete scripts/.validate_id_label_correspondence.sha256 - fix a stale "validator-pin job below" CI comment + reword the vendored-sync guard comment (no longer a self-pinned sha256) - refresh NEXT_TASKS + the next-tasks skill note (keep the out-flow caveat: TraitMech has originated cross-repo validator fixes before) schema-pin is a separate vendored set with no drift-check replacement — kept. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR removes the self-referential sha256 “validator pin” mechanism for the vendored id↔label validator set, relying instead on the shared-reference vendored-sync drift check (introduced previously) to prevent cross-repo divergence. It also updates internal documentation/comments to reflect the new enforcement model and refreshes the local backlog notes.
Changes:
- Deleted the self-generated sha256 pin file and removed the related
justrecipes/manifest. - Updated workflow and repo documentation/comments to describe
vendored-syncas the drift guard. - Refreshed
NEXT_TASKS.mdand thenext-tasksskill note to reflect the new propagation workflow via.vendored_canon_ref.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/.validate_id_label_correspondence.sha256 | Removes the deprecated self-generated sha256 pin manifest. |
| justfile | Deletes pin verify/refresh recipes and replaces them with an explanatory note about vendored-sync. |
| .github/workflows/label-correspondence.yaml | Updates comments describing the drift guard as vendored-sync rather than a pin job. |
| NEXT_TASKS.md | Updates Phase 2 validator notes to reflect retirement of the sha256 pin and the new hub-and-spoke drift check. |
| .claude/skills/next-tasks/SKILL.md | Updates skill documentation to reflect the new vendored-sync enforcement model and propagation flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+14
| # The vendored-sync job below is also blocking: it is fast and dependency-free, | ||
| # and guards the cross-repo byte-identical vendoring of the validator + tests via | ||
| # a shared-reference diff against the canonical hub (not a self-generated pin). |
Comment on lines
+282
to
+283
| # NOTE: the id↔label validator + its shared tests are vendored byte-identical | ||
| # across the Mech repos. The old self-generated sha256 pin (verify-/refresh- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the self-referential sha256 pin for the vendored id↔label validator set, now that the
vendored-syncshared-reference drift check (PR #176) is live and green in CI.Why
The old
verify-validator-pinderived its reference hash from the same repo it guarded, so all four Mech repos could passverifywhile holding three different versions — and that happened (this repo has originated cross-repo validator fixes before).vendored-syncfetches the reference from the canonical hub, so drift now fails CI. This removes the redundant second mechanism.Changes
verify-/refresh-validator-pinrecipes +VENDORED_IDLABEL_FILESmanifest fromjustfile.scripts/.validate_id_label_correspondence.sha256.vendored-syncguard comment.NEXT_TASKS.md+ thenext-tasksskill note (keeping the out-flow caveat).Scope
schema-pinis a separate vendored set — untouched. Companion PRs: CultureMech #111, MIM #156, CommunityMech #242.🤖 Generated with Claude Code