fix: compact idempotent summary rows, trailing newline, well-formed rows, counts/pluralization (closes #417)#447
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"I'm pecking through the errors..."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ❌ failure |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 1 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (87065/87065) |
Errors
- meaningful changed paths are not covered by an active change: src/commands/compact.rs, src/compact.rs
Action Items
- Review and fix -- meaningful changed paths are not covered by an active change: src/commands/compact.rs, src/compact.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
There was a problem hiding this comment.
❌ Corvin says...
_
<(;\ .oO(oh no...)
|/(\
\(\\
" "\\
"Caw... your imports are all over the place."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ❌ failure |
| Tests (build, test, clippy) | ❌ failure |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
❌ SpecSync: Failed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 1 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (87284/87284) |
Errors
- meaningful changed paths are not covered by an active change: specs/cli/cli.spec.md, specs/cli/context.md, specs/cli/requirements.md, specs/cli/tasks.md, specs/cli/testing.md, specs/cmd_archive_tasks/cmd_archive_tasks.spec.md, specs/cmd_archive_tasks/context.md, specs/cmd_archive_tasks/requirements.md, specs/cmd_archive_tasks/tasks.md, specs/cmd_archive_tasks/testing.md, specs/cmd_compact/cmd_compact.spec.md, specs/cmd_compact/context.md, specs/cmd_compact/requirements.md, specs/cmd_compact/tasks.md, specs/cmd_compact/testing.md, specs/compact/compact.spec.md, specs/compact/context.md, specs/compact/requirements.md, specs/compact/tasks.md, specs/compact/testing.md, src/commands/archive_tasks.rs, src/commands/compact.rs, src/compact.rs, src/main.rs, tests/integration/commands.rs
Action Items
- Review and fix -- meaningful changed paths are not covered by an active change: specs/cli/cli.spec.md, specs/cli/context.md, specs/cli/requirements.md, specs/cli/tasks.md, specs/cli/testing.md, specs/cmd_archive_tasks/cmd_archive_tasks.spec.md, specs/cmd_archive_tasks/context.md, specs/cmd_archive_tasks/requirements.md, specs/cmd_archive_tasks/tasks.md, specs/cmd_archive_tasks/testing.md, specs/cmd_compact/cmd_compact.spec.md, specs/cmd_compact/context.md, specs/cmd_compact/requirements.md, specs/cmd_compact/tasks.md, specs/cmd_compact/testing.md, specs/compact/compact.spec.md, specs/compact/context.md, specs/compact/requirements.md, specs/compact/tasks.md, specs/compact/testing.md, src/commands/archive_tasks.rs, src/commands/compact.rs, src/compact.rs, src/main.rs, tests/integration/commands.rs
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
025b315 to
d6c12fd
Compare
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Caw! Your code sparkles like a dropped french fry."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
✅ SpecSync: Passed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 0 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (110054/110054) |
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"That's a nice looking export you've got there."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
✅ SpecSync: Passed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 0 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (110054/110054) |
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
There was a problem hiding this comment.
✅ Corvin says...
_
<(^\ .oO(Caw! ^v^)
|/(\
\(\\
" "\\
"Looking sharp! Like a beak should be."
CI Summary
| Check | Status |
|---|---|
| Validate action.yml | ✅ Passed |
| Packaged Action Consumer | ✅ Passed |
| Dependency Audit | ✅ Passed |
| Code Coverage | ✅ Passed |
| Format Check | ✅ Passed |
| Docs Site | ✅ Passed |
| Spec Validation | ✅ Passed |
| Tests (build, test, clippy) | ✅ Passed |
| VS Code Extension | ✅ Passed |
📋 Spec Validation Details
✅ SpecSync: Passed
| Metric | Value |
|---|---|
| Specs checked | 62 |
| Passed | 62 |
| Errors | 0 |
| Warnings | 0 |
| File coverage | 100% (105/105) |
| LOC coverage | 100% (110054/110054) |
Generated by specsync · Run specsync check --format github to reproduce
Powered by corvid-pet
Summary
Fixes #417 completely for
compactand the relatedarchive-tasksoutput path.Lifecycle and review
CHG-0065-make-issue-417-changelog-compaction-idempotent-and-provide-truthful-portable-str4cb1f669e6892906b7ed9d78d872de1eb133de0725ceac4ef262ff7451d99984.main.Verification
fledge lanes run verifyspecsync check --strict --require-coverage 100 --forceCorvidLabs/spec-sync-sandboxdisposable-clone replayreviewat risk 40 and did not returnBLOCK.Test plan