fix(shared): preserve paragraph breaks in the Bot system prompt - #48
Open
arpan7sarkar wants to merge 1 commit into
Open
fix(shared): preserve paragraph breaks in the Bot system prompt#48arpan7sarkar wants to merge 1 commit into
arpan7sarkar wants to merge 1 commit into
Conversation
SYSTEM_PROMPT was an array of lines with "" entries marking paragraph
breaks, joined with .join(" "). That turns every break into a double
space instead of a real paragraph gap, collapsing the whole multi-section
prompt into one run-on string before it reaches the model.
Split the array into paragraphs (lines joined with a space) and join
paragraphs with a blank line instead.
arpan7sarkar
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
August 20, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47
SYSTEM_PROMPT was an array of lines with "" entries marking paragraph
breaks, joined with
.join(" "). That turned every break into a doublespace instead of a real paragraph gap, collapsing the whole multi-section
prompt into one run-on string before it reached the model.
Reproduced first:
SYSTEM_PROMPT.includes("\n")wasfalseand.includes(" ")wastrueon main.Fix: split the array into paragraphs (lines within a paragraph joined
with a space) and join paragraphs with a blank line, so the rendered
prompt has 5 clear paragraphs and zero double-spaces.
Added
shared/bot-prompt.test.tsto lock in both invariants.