Keep the computer fleet off a signed-in user's listing - #45
Open
kevin9327 wants to merge 1 commit into
Open
Conversation
The admin computers page asks for every Bot's machine. That list was behind a session only, so anyone signed in could read private coworker ids and whether those computers were running.
kevin9327
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
August 20, 2026 11:09
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
The admin computers page asks for every Bot's machine. That list lived behind a session only.
:botIdis unused, and the handler returnsgateway.computers(), so any signed-in person who could hit one valid bot path learned every Bot id and whether its computer was running, including private coworkers.This is not #35/#37 (acting as another Bot) or #29/#30 (a bot id becoming a filesystem path). It is the global listing, and it does not use the path id.
The approach
The same
requireAdminthe policy routes already use. A signed-in user is refused before the gateway is asked. An administrator still gets the fleet.Proof
bun test server/tests/computer-routes.test.ts— 2 pass, 0 failbunx biome format/linton the touched files — cleanTest plan
/admin/computersorGET /api/computers/<any-bot>/computers. Expect 403 and no fleet.