Skip to content

🎨 Palette: [빈 디렉토리 μƒνƒœ μ ‘κ·Όμ„± κ°œμ„ ]#176

Open
seonghobae wants to merge 4 commits into
masterfrom
palette-ux-empty-dir-accessibility-12329602747052026234
Open

🎨 Palette: [빈 디렉토리 μƒνƒœ μ ‘κ·Όμ„± κ°œμ„ ]#176
seonghobae wants to merge 4 commits into
masterfrom
palette-ux-empty-dir-accessibility-12329602747052026234

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What:

  • λΉ„μ–΄ μžˆλŠ” 디렉토리 λ Œλ”λ§ μ‹œ 좜λ ₯λ˜λŠ” 이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€. λ©”μ‹œμ§€λ₯Ό κ°μ‹ΈλŠ” <div>에 role="status"(ARIA 라이브 리전 μ—­ν• ) 속성을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why:

  • κΈ°μ‘΄μ—λŠ” 디렉토리가 λΉ„μ–΄ μžˆμ„ λ•Œ 이λ₯Ό 화면에 μ‹œκ°μ μœΌλ‘œλ§Œ ν‘œμ‹œν•˜μ—¬, 보쑰 κΈ°κΈ°(슀크린 리더 λ“±)λ₯Ό μ‚¬μš©ν•˜λŠ” μ‚¬μš©μžλŠ” μƒνƒœ λ³€ν™”λ‚˜ 빈 ν™”λ©΄μ˜ 의미λ₯Ό λͺ…ν™•νžˆ νŒŒμ•…ν•˜κΈ° μ–΄λ €μ› μŠ΅λ‹ˆλ‹€. role="status"λ₯Ό μΆ”κ°€ν•˜μ—¬ μ ‘κ·Όμ„± νŠΈλ¦¬μ— μƒνƒœ λ©”μ‹œμ§€λ‘œ μ „λ‹¬λ˜κ²Œ ν•¨μœΌλ‘œμ¨ μ΄λŸ¬ν•œ 문제λ₯Ό ν•΄κ²°ν•©λ‹ˆλ‹€.

πŸ“Έ Before/After:

  • Before: <div class="empty-dir">이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</div>
  • After: <div class="empty-dir" role="status">이 λ””λ ‰ν† λ¦¬λŠ” λΉ„μ–΄ μžˆμŠ΅λ‹ˆλ‹€.</div>

β™Ώ Accessibility:

  • ARIA live region κΈ°λŠ₯을 ν™œμš©ν•΄ 슀크린 리더가 빈 디렉토리 μƒνƒœλ₯Ό λͺ…ν™•νžˆ μ‚¬μš©μžμ—κ²Œ 읽어주도둝 μ‹œλ§¨ν‹± λ§ˆν¬μ—…μ„ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

PR created automatically by Jules for task 12329602747052026234 started by @seonghobae

μƒμ„±λœ 디렉토리 트리의 HTMLμ—μ„œ, λͺ©λ‘μ΄ λΉ„μ–΄ μžˆμ„ λ•Œ ν‘œμ‹œλ˜λŠ” ν…μŠ€νŠΈ μš”μ†Œμ— `role="status"` 속성을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
이λ₯Ό 톡해 ν™”λ©΄ νŒλ…κΈ°(슀크린 리더) μ‚¬μš©μžκ°€ μ‹œκ°μ  λ‹¨μ„œ 없이도 디렉토리가 λΉ„μ–΄ μžˆλ‹€λŠ” μƒνƒœ λ³€ν™”λ₯Ό λͺ…ν™•ν•˜κ²Œ 인지할 수 μžˆλ„λ‘ 접근성을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

μƒμ„±λœ 디렉토리 트리의 HTMLμ—μ„œ, λͺ©λ‘μ΄ λΉ„μ–΄ μžˆμ„ λ•Œ ν‘œμ‹œλ˜λŠ” ν…μŠ€νŠΈ μš”μ†Œμ— `role="status"` 속성을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
이λ₯Ό 톡해 ν™”λ©΄ νŒλ…κΈ°(슀크린 리더) μ‚¬μš©μžκ°€ μ‹œκ°μ  λ‹¨μ„œ 없이도 디렉토리가 λΉ„μ–΄ μžˆλ‹€λŠ” μƒνƒœ λ³€ν™”λ₯Ό λͺ…ν™•ν•˜κ²Œ 인지할 수 μžˆλ„λ‘ 접근성을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
μƒμ„±λœ 디렉토리 트리의 HTMLμ—μ„œ, λͺ©λ‘μ΄ λΉ„μ–΄ μžˆμ„ λ•Œ ν‘œμ‹œλ˜λŠ” ν…μŠ€νŠΈ μš”μ†Œμ— `role="status"` 속성을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
이λ₯Ό 톡해 ν™”λ©΄ νŒλ…κΈ°(슀크린 리더) μ‚¬μš©μžκ°€ μ‹œκ°μ  λ‹¨μ„œ 없이도 디렉토리가 λΉ„μ–΄ μžˆλ‹€λŠ” μƒνƒœ λ³€ν™”λ₯Ό λͺ…ν™•ν•˜κ²Œ 인지할 수 μžˆλ„λ‘ 접근성을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
μƒμ„±λœ HTML λͺ©λ‘μ΄ λΉ„μ–΄ μžˆμ„ λ•Œ ν™”λ©΄ νŒλ…κΈ°(슀크린 리더) μ‚¬μš©μžκ°€ μ‹œκ°μ  λ‹¨μ„œ 없이도 디렉토리가 λΉ„μ–΄ μžˆλ‹€λŠ” μƒνƒœλ₯Ό λͺ…ν™•ν•˜κ²Œ 인지할 수 μžˆλ„λ‘ `role="status"` 속성을 μΆ”κ°€ν•˜μ˜€μŠ΅λ‹ˆλ‹€.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant