Skip to content

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œ 빈 λ¬Έμžμ—΄ 처리 κ°œμ„ #267

Open
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-empty-string-validation-13549262994498244952
Open

🎨 Palette: 숫자 μž…λ ₯ ν•„λ“œ 빈 λ¬Έμžμ—΄ 처리 κ°œμ„ #267
seonghobae wants to merge 1 commit into
mainfrom
palette-fix-empty-string-validation-13549262994498244952

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: target_bytes와 batch_target_bytes 숫자 μž…λ ₯ ν•„λ“œμ˜ inline μœ νš¨μ„± 검사 λ‘œμ§μ— 빈 λ¬Έμžμ—΄(empty string) 검사λ₯Ό μΆ”κ°€ν•˜μ—¬ μ‚¬μš©μžκ°€ 값을 μ§€μšΈ λ•Œ 였λ₯˜ λ©”μ‹œμ§€κ°€ ν•΄μ œλ˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: 빈 λ¬Έμžμ—΄μ„ νŒŒμ‹±ν•˜λ©΄ NaN이 λ°˜ν™˜λ˜μ–΄ κΈ°λ³Έ HTML5 μ œμ•½ 쑰건(예: required)이 μž‘λ™ν•˜κΈ° 전에 '0보닀 컀야 ν•©λ‹ˆλ‹€'λΌλŠ” λΆ€μ •ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ˜μ–΄ μ‚¬μš©μžμ—κ²Œ ν˜Όλž€μ„ 쀄 수 μžˆμ—ˆμŠ΅λ‹ˆλ‹€. 이 λ³€κ²½μœΌλ‘œ λΆˆν•„μš”ν•œ 였λ₯˜κ°€ ν‘œμ‹œλ˜μ§€ μ•Šκ³  μžμ—°μŠ€λŸ¬μš΄ μž…λ ₯ κ²½ν—˜μ„ μ œκ³΅ν•©λ‹ˆλ‹€.
πŸ“Έ Before/After: ν•΄λ‹Ή μ—†μŒ (동적 검증 μ‹œλ‚˜λ¦¬μ˜€ κ°œμ„ )
β™Ώ Accessibility: 슀크린 리더 μ‚¬μš©μžκ°€ μž…λ ₯λž€μ„ 비웠을 λ•Œ λΆ€μ μ ˆν•˜κ²Œ aria-invalid="true"κ°€ μœ μ§€λ˜λŠ” ν˜„μƒμ„ λ°©μ§€ν•˜μ—¬ μ •ν™•ν•œ 폼 μƒνƒœλ₯Ό μ•ˆλ‚΄ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 13549262994498244952 started by @seonghobae

πŸ’‘ What: `target_bytes`와 `batch_target_bytes` 숫자 μž…λ ₯ ν•„λ“œμ˜ inline μœ νš¨μ„± 검사 λ‘œμ§μ— 빈 λ¬Έμžμ—΄(empty string) 검사λ₯Ό μΆ”κ°€ν•˜μ—¬ μ‚¬μš©μžκ°€ 값을 μ§€μšΈ λ•Œ 였λ₯˜ λ©”μ‹œμ§€κ°€ ν•΄μ œλ˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: 빈 λ¬Έμžμ—΄μ„ νŒŒμ‹±ν•˜λ©΄ `NaN`이 λ°˜ν™˜λ˜μ–΄ κΈ°λ³Έ HTML5 μ œμ•½ 쑰건(예: required)이 μž‘λ™ν•˜κΈ° 전에 '0보닀 컀야 ν•©λ‹ˆλ‹€'λΌλŠ” λΆ€μ •ν™•ν•œ 였λ₯˜ λ©”μ‹œμ§€κ°€ ν‘œμ‹œλ˜μ–΄ μ‚¬μš©μžμ—κ²Œ ν˜Όλž€μ„ 쀄 수 μžˆμ—ˆμŠ΅λ‹ˆλ‹€. 이 λ³€κ²½μœΌλ‘œ λΆˆν•„μš”ν•œ 였λ₯˜κ°€ ν‘œμ‹œλ˜μ§€ μ•Šκ³  μžμ—°μŠ€λŸ¬μš΄ μž…λ ₯ κ²½ν—˜μ„ μ œκ³΅ν•©λ‹ˆλ‹€.
β™Ώ Accessibility: 슀크린 리더 μ‚¬μš©μžκ°€ μž…λ ₯λž€μ„ 비웠을 λ•Œ λΆ€μ μ ˆν•˜κ²Œ aria-invalid="true"κ°€ μœ μ§€λ˜λŠ” ν˜„μƒμ„ λ°©μ§€ν•˜μ—¬ μ •ν™•ν•œ 폼 μƒνƒœλ₯Ό μ•ˆλ‚΄ν•©λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant