Skip to content

🎨 Palette: μž…λ ₯ ν•„λ“œκ°€ λΉ„μ–΄μžˆμ„ λ•Œ 잘λͺ»λœ μœ νš¨μ„± 검사 λ©”μ‹œμ§€ ν‘œμ‹œ 문제 ν•΄κ²°#248

Open
seonghobae wants to merge 4 commits into
mainfrom
palette-empty-validation-13967377247692307759
Open

🎨 Palette: μž…λ ₯ ν•„λ“œκ°€ λΉ„μ–΄μžˆμ„ λ•Œ 잘λͺ»λœ μœ νš¨μ„± 검사 λ©”μ‹œμ§€ ν‘œμ‹œ 문제 ν•΄κ²°#248
seonghobae wants to merge 4 commits into
mainfrom
palette-empty-validation-13967377247692307759

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ What: μž…λ ₯ ν•„λ“œ(Target Bytes)의 ν…μŠ€νŠΈκ°€ μ§€μ›Œμ Έ 빈 λ¬Έμžμ—΄μ΄ λ˜μ—ˆμ„ λ•Œ, 'Must be greater than 0.' λΌλŠ” μ—λŸ¬ λ©”μ‹œμ§€κ°€ 인라인 미리보기 ν…μŠ€νŠΈμ— λ‚˜νƒ€λ‚˜μ§€ μ•Šλ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: JavaScript의 parseIntκ°€ 빈 λ¬Έμžμ—΄μ„ NaN으둜 νŒŒμ‹±ν•˜μ—¬ μœ νš¨μ„± 검증을 μ‹€νŒ¨ν•˜κ²Œ λ§Œλ“­λ‹ˆλ‹€. μ‚¬μš©μžκ°€ μž…λ ₯을 μˆ˜μ •ν•˜λ €κ³  ν•„λ“œλ₯Ό λΉ„μšΈ λ•Œ λΉ¨κ°„μƒ‰μœΌλ‘œ μ—λŸ¬λ₯Ό 뿜으면 UXκ°€ λ–¨μ–΄μ§‘λ‹ˆλ‹€. ν•„λ“œκ°€ λΉ„μ–΄μžˆμ„ λ•ŒλŠ” HTML5의 λ„€μ΄ν‹°λΈŒ required 속성이 역할을 λ‹€ ν•˜λ„λ‘ 미리보기 ν…μŠ€νŠΈλ₯Ό λΉ„μ›Œμ€λ‹ˆλ‹€.
πŸ“Έ Before/After: ν•„λ“œμ˜ λ‚΄μš©μ„ λͺ¨λ‘ μ§€μš°λ©΄ λΉ¨κ°„μƒ‰μ˜ μ—λŸ¬ λ©”μ‹œμ§€κ°€ λ‚˜μ˜€λŠ” λŒ€μ‹  κΉ”λ”ν•˜κ²Œ 빈칸으둜 λ‚¨κ²Œ λ©λ‹ˆλ‹€.
β™Ώ Accessibility: 슀크린 리더 μ‚¬μš©μžμ™€ ν‚€λ³΄λ“œ μ‚¬μš©μžμ—κ²Œ 빈 ν…μŠ€νŠΈ μƒν™©μ—μ„œ λœμ»Ήκ±°λ¦¬λŠ” μ—λŸ¬ λ©”μ‹œμ§€(aria-live μ˜μ—­μ—μ„œ 계속 쀑볡 μ•ˆλ‚΄)λ₯Ό 쀄여 λΆˆν•„μš”ν•œ 인지 λΆ€ν•˜λ₯Ό μ—†μ• μ€λ‹ˆλ‹€.


PR created automatically by Jules for task 13967377247692307759 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant