π¨ Palette: λμ ν μ΄λΈ μ»΄ν¬λνΈ μ κ·Όμ± λ° λ²νΌ λ‘λ© μν κ°μ #162
π¨ Palette: λμ ν
μ΄λΈ μ»΄ν¬λνΈ μ κ·Όμ± λ° λ²νΌ λ‘λ© μν κ°μ #162seonghobae wants to merge 4 commits into
Conversation
- λμ ν μ΄λΈ μμ± μ λ²νΌ λ° λ§ν¬μ contextual aria-label μΆκ° - λΉλκΈ° λ‘λ© μ€ λͺ μμ μΈ aria-busy μμ± μ μ© - λ‘λ© μν μ ν μ μλ³Έ DOM 보쑴μ μν innerHTML μ¬μ© ν¨ν΄μΌλ‘ ν΅μΌ - ν μ€νΈ μ½λ (ViewerUiControllerTest) λ΄ κ²μ¦ λ‘μ§ μ λ°μ΄νΈ - .jules/palette.md μ κ·Όμ± νμ΅ λ΄μ© κΈ°λ‘
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- λμ ν μ΄λΈ μμ± μ λ²νΌ λ° λ§ν¬μ contextual aria-label μΆκ° - λΉλκΈ° λ‘λ© μ€ λͺ μμ μΈ aria-busy μμ± μ μ© - λ‘λ© μν μ ν μ μλ³Έ DOM 보쑴μ μν innerHTML μ¬μ© ν¨ν΄μΌλ‘ ν΅μΌ - ν μ€νΈ μ½λ (ViewerUiControllerTest) λ΄ κ²μ¦ λ‘μ§ μ λ°μ΄νΈ - .jules/palette.md μ κ·Όμ± νμ΅ λ΄μ© κΈ°λ‘
- λμ ν μ΄λΈ μμ± μ λ²νΌ λ° λ§ν¬μ contextual aria-label μΆκ° - λΉλκΈ° λ‘λ© μ€ λͺ μμ μΈ aria-busy μμ± μ μ© - λ‘λ© μν μ ν μ μλ³Έ DOM 보쑴μ μν innerHTML μ¬μ© ν¨ν΄μΌλ‘ ν΅μΌ - ν μ€νΈ μ½λ (ViewerUiControllerTest) λ΄ κ²μ¦ λ‘μ§ μ λ°μ΄νΈ - .jules/palette.md μ κ·Όμ± νμ΅ λ΄μ© κΈ°λ‘
- λμ ν μ΄λΈ μμ± μ λ²νΌ λ° λ§ν¬μ contextual aria-label μΆκ° - λΉλκΈ° λ‘λ© μ€ λͺ μμ μΈ aria-busy μμ± μ μ© - λ‘λ© μν μ ν μ μλ³Έ DOM 보쑴μ μν innerHTML μ¬μ© ν¨ν΄μΌλ‘ ν΅μΌ - ν μ€νΈ μ½λ (ViewerUiControllerTest) λ΄ κ²μ¦ λ‘μ§ μ λ°μ΄νΈ - .jules/palette.md μ κ·Όμ± νμ΅ λ΄μ© κΈ°λ‘
μ΄ PRμ Palette μν λ‘μ Clearfolio λ·°μ΄ μΈν°νμ΄μ€μ μκ·λͺ¨ UX λ° μ κ·Όμ±μ ν₯μμν΅λλ€.
aria-labelμ λΆμ¬νμ¬ μ€ν¬λ¦° 리λ μ¬μ©μμ μ΄ν΄λλ₯Ό λμμ΅λλ€.demo.jsμ λͺ¨λ λΉλκΈ° μμ λ²νΌμ λν΄ λ‘λ© μμ μ λͺ μμ μΈaria-busy="true"μμ±μ λΆμ¬νμ¬ μ€ν¬λ¦° 리λκ° μ²λ¦¬ μ€μμ μ μ μλλ‘ νμ΅λλ€.Array.from(childNodes)λ°©μμμ νλ‘μ νΈ νμ€μΈinnerHTMLμ μμ λ³μμ μ μ₯νκ³ λ³΅μνλ λ°©μμΌλ‘ ν΅μΌνμ¬ κ΅¬μ‘° λ³ν 리μ€ν¬λ₯Ό μ€μμ΅λλ€.ViewerUiControllerTest.javaνμΌμ κ²μ¦ λ‘μ§μ μ λ°μ΄νΈ νμμ΅λλ€.PR created automatically by Jules for task 18084169557556592466 started by @seonghobae