π¨ Palette: [UX improvement] μ 보 λ·°μ΄ μμ΄μ½ λ²νΌμ ν΄ν λ° μ κ·Όμ±(aria-disabled) ν₯μ#643
Conversation
ScoreViewer μ»΄ν¬λνΈμ μμ΄μ½ λ²νΌ(μ΄μ /λ€μ νμ΄μ§, νλ/μΆμ λ±)λ€μ λν΄ λ€μ΄ν°λΈ `disabled` μμ± λμ `aria-disabled` μμ±κ³Ό `title` ν΄νμ μΆκ°νμ¬ ν€λ³΄λ λ΄λΉκ²μ΄μ μ¬μ©μμ μ€ν¬λ¦° 리λ νκ²½μμμ μ κ·Όμ±μ κ°μ νμ΅λλ€. λν μ»΄ν¬λνΈ νκ³μΉμμμ λΉνμ±ν λμμ λ§κΈ° μν΄ ν΄λ¦ μ΄λ²€νΈ νΈλ€λ¬ λ΄λΆμμ μμ νκ² μ€νμ μ°¨λ¨(early return)νλλ‘ λ³΄κ°νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
ScoreViewer λ΄μ μμ΄μ½ μ μ© λ²νΌ(μ΄μ /λ€μ νμ΄μ§, νλ/μΆμ λ±)μ μκ°μ ν΄ν(title)μ μ 곡νκ³ , λΉνμ±ν μμ±μ native disabled λμ aria-disabledλ‘ λ³κ²½νμ¬ μ κ·Όμ±(ν€λ³΄λ ν¬μ»€μ€)μ κ°ννμ΅λλ€.
ScoreViewer λ΄μ μμ΄μ½ μ μ© λ²νΌ(μ΄μ /λ€μ νμ΄μ§, νλ/μΆμ λ±)μ μκ°μ ν΄ν(title)μ μ 곡νκ³ , λΉνμ±ν μμ±μ native disabled λμ aria-disabledλ‘ λ³κ²½νμ¬ μ κ·Όμ±(ν€λ³΄λ ν¬μ»€μ€)μ κ°ννμ΅λλ€.
ScoreViewer λ΄μ μμ΄μ½ μ μ© λ²νΌ(μ΄μ /λ€μ νμ΄μ§, νλ/μΆμ λ±)μ μκ°μ ν΄ν(title)μ μ 곡νκ³ , λΉνμ±ν μμ±μ native disabled λμ aria-disabledλ‘ λ³κ²½νμ¬ μ κ·Όμ±(ν€λ³΄λ ν¬μ»€μ€)μ κ°ννμ΅λλ€.
π‘ What:
ScoreViewer λ΄μ μμ΄μ½ λ²νΌ(μ΄μ νμ΄μ§, λ€μ νμ΄μ§, νλ, μΆμ)λ€μ λν΄ νΈλ² μ μ 보λ₯Ό μ 곡ν μ μλλ‘
titleμμ±μ μΆκ°νκ³ , λΉνμ±ν μ²λ¦¬ μ λ€μ΄ν°λΈdisabledμμ± λμaria-disabled="true"λ₯Ό μ¬μ©νλλ‘ μμ νμ΅λλ€. κ΄λ ¨λ ν΄λ¦ νΈλ€λ¬λ€μλ λΉνμ±ν 쑰건 μ μ‘°κΈ° λ°ν(early return)νμ¬ ν΄λ¦ μ΄λ²€νΈκ° λ°μνμ§ μλλ‘ μ‘°μΉνμ΅λλ€.π― Why:
λ€μ΄ν°λΈ
disabledμμλ ν€λ³΄λ ν¬μ»€μ€(Tab) μ΄λ μμμμ μ μΈλλ©° ν΄ν λμ λν λ°©ν΄ν©λλ€.aria-disabledμμ±μ μ¬μ©νμ¬ ν¬μ»€μ€λ₯Ό μ μ§νκ² ν¨μΌλ‘μ¨, μ€ν¬λ¦° 리λ μ¬μ©μμ ν€λ³΄λ μ΄λ μ¬μ©μ λͺ¨λκ° λ²νΌμ μ‘΄μ¬μ μν(λΉνμ±ν μ¬λΆ)λ₯Ό μ½κ² μΈμ§ν μ μλλ‘ μ κ·Όμ±κ³Ό UXλ₯Ό κ°μ νκΈ° μν¨μ λλ€.πΈ Before/After:
aria-disabledμνλ‘ λ³νλλ©° Tab ν¬μ»€μ€λ μ μ§λ¨.βΏ Accessibility:
titleμμ±μ λΆμ¬νμ¬ λ§μ°μ€ μ¬μ©μ λ° μ€ν¬λ¦°λ¦¬λμκ² λͺ νν λ§₯λ½(Tooltip)μ μ 곡ν©λλ€.disabledμμ±μ μ κ±°ν¨μΌλ‘μ¨ μ€ν¬λ¦° 리λκ° μμμ μ‘΄μ¬ μ체λ₯Ό 무μνμ§ μκ³ , λΉνμ±νλ μ΄μ λ₯Ό λͺ ννκ² μ μ μλλ‘ μ§μν©λλ€.PR created automatically by Jules for task 11209809002286895946 started by @seonghobae