fix(review): preserve full-hour sessions in .github/workflows/opencode-review.yml#566
Open
seonghobae wants to merge 4 commits into
Open
fix(review): preserve full-hour sessions in .github/workflows/opencode-review.yml#566seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Noema PydanticAI review
All check and dependency gates pass, with evidence confirming that the PR's behavioral intent (to preserve full-hour model-pool review sessions in OpenCode workflows, robust R package-aware evidence, and reliable recovery from provider timeouts or HTTP 5xx failures) is implemented thoroughly. The diff delivers:
- Increased model pool and dynamic cadence session/budget timeouts (from 10–60min to 90–195min bounds) everywhere in .github/workflows/opencode-review.yml and run_opencode_review_model_pool.sh, matching approval/test expectations.
- Improved handling of paid session timeouts: after a hung or killed attempt, the runner attempts to recover persisted partial results via OpenCode session export by title, before falling through, tested and contract-guarded in test_opencode_model_pool_runner.py and test_opencode_agent_contract.py.
- Improvements for R package evidence and test handling (conditionally awaiting completed package checks, improved result reporting, new output bindings) in opencode-review.yml and the test gate (test_strix_quick_gate.sh confirms workflow behavior).
- Extra resilience and coverage in error classification, session export, logic to advance/skipping on provider failure signatures.
- All tests, SAST, dependency, and workflow checks are green; no regressions or behavioral divergences are reported by CI, contract, or regression tests.
All new/changed behavior is protected by tests. No blocking issue is evidenced. Approving.
Findings
-
No blocking findings.
-
Result: APPROVE
-
Verdict: approve
-
Confidence: high
-
Head SHA:
df408934021a206be6029838546c72094ca528ef -
Reviewer credential:
noema-github-app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Preserve legitimate long-running OpenCode review sessions and retain valid model work without weakening any review, check, or ruleset gate.
Current-head evidence
Verification
No branch protection, approval count, required workflow, review identity, or security gate is relaxed.