⚡ Bolt: JSON 추출 시 문자열 슬라이싱을 제거하여 최적화#561
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headacf53e5ba041ab5b4af0d64c7e9a7a9019494e07. -
Head SHA:
acf53e5ba041ab5b4af0d64c7e9a7a9019494e07 -
Workflow run: 29339294203
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["CI script: noema_review_gate.py"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: noema_review_gate.py"]
R2 --> V2["bash -n plus Strix self-test"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: bolt.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: bolt.md"]
R1 --> V1["required checks"]
Evidence --> S2["CI script: noema_review_gate.py"]
S2 --> I2["review and security gate shell path"]
I2 --> R2["Review risk: CI script: noema_review_gate.py"]
R2 --> V2["bash -n plus Strix self-test"]
|
1 participant
💡 What:
scripts/ci/noema_review_gate.py의extract_json_object함수에서stripped[start : end + 1]를 통한 문자열 슬라이싱을 제거하고json.JSONDecoder().raw_decode(stripped, start)를 사용하도록 수정했습니다.🎯 Why: 기존 코드는 LLM 응답 텍스트에서 JSON을 추출할 때 불필요하게 문자열 복사를 발생시키는 O(N) 오버헤드가 있었습니다. 또한, LLM이 JSON 반환 후 후행 설명 텍스트에
}를 포함할 경우.rfind("}")가 잘못된 끝점을 잡아 파싱 에러를 유발하는 버그가 있었습니다.📊 Impact: 문자열 슬라이싱으로 인한 불필요한 메모리 할당을 방지하고, LLM의 비정상적인 후행 텍스트(garbage text)에도 안전하게 첫 번째 JSON 객체만을 정확히 추출하여 견고성을 크게 향상시켰습니다.
🔬 Measurement:
pytest tests/test_noema_review_gate.py실행을 통해 모든 테스트가 통과하는지 확인했으며,bandit및interrogate등 정적 분석과 100% 커버리지를 유지합니다.PR created automatically by Jules for task 3856684195609986451 started by @seonghobae