kernel: re-home HDC drift annotation from WF11 to WF15#55
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-homes HDC drift annotation relations from WF11 to WF15 by emitting open-semantic link claims with a dedicated contract URN, and updates the reactive test to assert the new shape.
Changes:
- Emit drift annotation links as
WF15with{semantic}ports and a specificContractURN. - Update the drift annotation test to look for
WF15+ matchingContractURN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/kernel/runtime.go | Changes drift annotation emission to WF15 semantic links and adds a contract URN. |
| internal/kernel/runtime_reactive_test.go | Updates assertions to match the new WF15 + contract-based relation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+891
to
+902
| RewriteType: graph.LINK, | ||
| // Re-home drift annotations to WF15 open-semantic links. | ||
| // WF11 only declares synced-via/sync-target; the old tagged/tagged-in | ||
| // pair was rejected by the declaration gate (moos-kernel#52). | ||
| RewriteCategory: graph.WF15, | ||
| Actor: actor, | ||
| RelationURN: relURN, | ||
| SrcURN: claimURN, | ||
| SrcPort: "tagged", | ||
| SrcPort: "{semantic}", | ||
| TgtURN: row.URN, | ||
| TgtPort: "tagged-in", | ||
| TgtPort: "{semantic}", | ||
| ContractURN: "urn:moos:contract:hdc-drift-annotation.v1", |
Fold Copilot PR #55 nit by centralizing semantic port + contract URN constants and reusing them in runtime tests. authored-by: agent:vscode.hp-laptop.wolfram / session:sam.kernel-proper / t250-wf11-drift-annotation-rehome
Collaborator
Author
|
Folded Copilot nit from #147 conventions brief:
Validation: go test ./... passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HG URN: urn:moos:session:sam.kernel-proper
Summary
Why
WF11 only declares synced-via/sync-target, so tagged/tagged-in was rejected by the declaration gate and silently dropped from the emitter perspective.
Validation
Closes #52