London | 26-ITP-May | Khaliun Baatarkhuu | Sprint 3 | Dead code

[khaliun-dev]

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

I have learnt to see what parts of code are considered unreachable and redundant. Also, saw a glimpse of what "filter → transform → aggregate" pattern looks like, with the second exercise.

Questions

None.

[tiakavousi]

Nice work identifying the redundant and unreachable code.
One suggestion I'd make is to apply the changes directly to the original code rather than keeping both the original and the updated versions, and to remove the explanatory comments once you've finished in both excercises.

In a real codebase, reviewers should be able to quickly spot the actual changes in a pull request. Keeping dead code or temporary explanations can make the diff harder to read. Think of these exercises as if you're working on production code: clean up the redundant code, refactor where needed, and leave the file in a clean, maintainable state.

[khaliun-dev]

hi @tiakavousi , thank you for reviewing my PR. I have removed all the unnecessary fluff and made it a clean as possible.
Can you please have another look and, if it's good, put a "completed" label?

Cheers.