Skip to content

Cape Town| 26-ITP-May|Enice Mutanda| Sprint 3 |Practice-Tdd#1531

Open
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:coursework/sprint-3-practice-tdd
Open

Cape Town| 26-ITP-May|Enice Mutanda| Sprint 3 |Practice-Tdd#1531
Enice-Codes wants to merge 2 commits into
CodeYourFuture:mainfrom
Enice-Codes:coursework/sprint-3-practice-tdd

Conversation

@Enice-Codes

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed the card value exercise
the dependent file exercise
the dead code

@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Structuring-And-Testing-Data The name of the module. labels Jul 19, 2026

@hey-hammad hey-hammad left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the exercise again and fix the implementation. Thanks

}

module.exports = countChar;
test( "should count multiple occurrences of a character ", function(){

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all test are supposed to be in the .test.js file only

// Given a string `str` and a single character `char` to search for,
// When the countChar function is called with these inputs,
// Then it should:
function CountChar(str, char) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic should be in .js file, here it should in the count.js file.

@@ -1,5 +1,15 @@
function getOrdinalNumber(num) {
return "1st";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please implement the code logic for the function here.

@hey-hammad hey-hammad added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Structuring-And-Testing-Data The name of the module. Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants