Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Alarm Clock - #1273
Open
Niangh-Ciang wants to merge 4 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Alarm Clock#1273Niangh-Ciang wants to merge 4 commits into
Niangh-Ciang wants to merge 4 commits into
Conversation
Niangh-Ciang
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start, but there are a couple of things you need to check again
| @@ -1,4 +1,23 @@ | |||
| function setAlarm() {} | |||
| function setAlarm() { | |||
There was a problem hiding this comment.
Have you properly handled input validation?
Author
There was a problem hiding this comment.
I’ve added input validation so the alarm will show a message when no time is set or when the time is zero or negative.
| const timeRemainingDisplay = document.getElementById("timeRemaining"); | ||
|
|
||
| timeRemainingDisplay.innerText = `Time Remaining: ${formatTime(remainingTime)}`; | ||
| const countdownInterval = setInterval(() => { |
There was a problem hiding this comment.
What happens if there is already an alarm countdown happening and you start another one?
Author
There was a problem hiding this comment.
If a countdown is already running and I start a new one, the old countdown doesn’t stop. This makes the timer behave incorrectly sometimes it goes faster or skips numbers because two countdowns are running at the same time.
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Completed full implementation in alarmclock.js.