Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Quote Generator - #1258
Open
Niangh-Ciang wants to merge 6 commits into
Open
Glasgow | 26-ITP-May | Niangh Ciang | Sprint 3 | Quote Generator#1258Niangh-Ciang wants to merge 6 commits into
Niangh-Ciang wants to merge 6 commits into
Conversation
Niangh-Ciang
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Jul 27, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Great work, there's just one part where I have a suggestion for an improvement
| // call pickFromArray with the quotes array to check you get a random quote | ||
| function showRandomQuote() { | ||
| const randomQuote = pickFromArray(quotes); | ||
| const quoteElement = document.querySelector("#quote"); |
There was a problem hiding this comment.
If you are using IDs, is there a better method to use than querySelector?
Author
There was a problem hiding this comment.
Yes, using getElementById is better for ID selectors.
LonMcGregor
added
Reviewed
Niangh-Ciang
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Complete quote generator with button interaction and auto‑play feature