feat(reports): #233 Upload Reports Modal - #260
Conversation
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Just some questions about the backend diffs, otherwise this is looking good!
| @@ -1,22 +1,17 @@ | |||
| FROM node:20-alpine | |||
|
|
|||
| WORKDIR /app | |||
There was a problem hiding this comment.
was the docker file broken without these changes?
There was a problem hiding this comment.
Yes, it couldn't find the shared/types directory when importing @branch/types, as shared is on the same level as apps, so the auth container build was failing locally when running from apps/backend
| build: | ||
| context: ./lambdas/auth | ||
| dockerfile: Dockerfile | ||
| context: ../.. |
There was a problem hiding this comment.
I think wed want this ./lambdas/auth since wed run this from backend
There was a problem hiding this comment.
good catch, but I think the context also needs to be ../.. here since the Dockerfile copies from shared/types/, which is in the monorepo root (instead of in apps/backend) ?
all the other lambda containers use ../.. for the same reason I believe (they copy shared/lambda-auth/)
There was a problem hiding this comment.
oh duh yes that makes sense, thank you
nourshoreibah
added
test-environment
tsudhakar87
changed the title
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
thanks for your answers!
3 participants
ℹ️ Issue
Closes #233
📝 Description
Implemented end-to-end functionality for uploading reports
Changes:
✔️ Verification
(I changed title to just be "test" after several iterations of testing)
I got my token by hitting the auth /login endpoint, then inserted myself as an admin into the users table with the cognito_sub decoded from the token, then saved this as
branch_access_token(key) with the token (value) in local storage. Then I was able to see all the projects on the page (added the modal locally to test and view this below:)(old photos)
(new photos on the reports page)
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!