Skip to content

Import instrument-hooks directly to set exec-harness metadata - #231

Closed
GuillaumeLagrange wants to merge 4 commits into
mainfrom
cod-1736-use-correct-post-processing-depending-on-the-language
Closed

Import instrument-hooks directly to set exec-harness metadata#231
GuillaumeLagrange wants to merge 4 commits into
mainfrom
cod-1736-use-correct-post-processing-depending-on-the-language

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

No description provided.

@codspeed-hq

codspeed-hq Bot commented Feb 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-1736-use-correct-post-processing-depending-on-the-language (55ba14d) with main (be55547)

Open in CodSpeed

@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1736-use-correct-post-processing-depending-on-the-language branch from 9be28b1 to 150ff2f Compare February 2, 2026 17:06
@GuillaumeLagrange
GuillaumeLagrange requested review from art049 and not-matthias and removed request for art049 February 3, 2026 15:26
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1736-use-correct-post-processing-depending-on-the-language branch from c4b1532 to 6279c9b Compare February 4, 2026 21:08

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, two minor comments

Comment thread crates/exec-harness/build.rs
Comment thread src/executor/memory/executor.rs
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1736-use-correct-post-processing-depending-on-the-language branch from 6279c9b to f802d48 Compare February 6, 2026 16:04
@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-1736-use-correct-post-processing-depending-on-the-language branch from f802d48 to 55ba14d Compare February 9, 2026 08:16
@GuillaumeLagrange

Copy link
Copy Markdown
Contributor Author

Merging alongside #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants