Skip to content

Stop parsing /proc/pid/maps and only rely on perf trace for unwind data - #224

Merged
GuillaumeLagrange merged 4 commits into
mainfrom
cod-1920-stop-outputting-perfdata-in-profiling-cli
Jan 29, 2026
Merged

Stop parsing /proc/pid/maps and only rely on perf trace for unwind data#224
GuillaumeLagrange merged 4 commits into
mainfrom
cod-1920-stop-outputting-perfdata-in-profiling-cli

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

No description provided.

Stop reading `/proc/<pid>/maps` during execution.
No idea whay these were not picked up by clippy, but rust-analyzer
spotted them.
@codspeed-hq

codspeed-hq Bot commented Jan 28, 2026

Copy link
Copy Markdown

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing cod-1920-stop-outputting-perfdata-in-profiling-cli (41dc598) with main (6e5891e)

Summary

✅ 4 untouched benchmarks

Due to the sequential nature of the perf file parsing, these are pretty
much all the easy optimizations that we can have
@GuillaumeLagrange
GuillaumeLagrange marked this pull request as ready for review January 28, 2026 18:07

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GuillaumeLagrange
GuillaumeLagrange merged commit 41dc598 into main Jan 29, 2026
13 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the cod-1920-stop-outputting-perfdata-in-profiling-cli branch January 29, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants