Skip to content

Implement codspeed use mode to define mode for shell session - #221

Merged
GuillaumeLagrange merged 5 commits into
mainfrom
cod-2102-implement-codspeed-use-mode-to-define-mode-for-shell-session
Jan 27, 2026
Merged

Implement codspeed use mode to define mode for shell session#221
GuillaumeLagrange merged 5 commits into
mainfrom
cod-2102-implement-codspeed-use-mode-to-define-mode-for-shell-session

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

Also finished the refactor that was started when first implementing exec-harness to remove a lot of the logc that was nested in the run module

@codspeed-hq

codspeed-hq Bot commented Jan 27, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 4 untouched benchmarks


Comparing cod-2102-implement-codspeed-use-mode-to-define-mode-for-shell-session (22373e8) with main (42bf300)

Open in CodSpeed

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor looks good, but let's discuss how to set the mode.

Comment thread src/runner_mode/shell_session.rs
@not-matthias
not-matthias self-requested a review January 27, 2026 16:34

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuillaumeLagrange
GuillaumeLagrange merged commit 22373e8 into main Jan 27, 2026
13 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the cod-2102-implement-codspeed-use-mode-to-define-mode-for-shell-session branch January 27, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants