Make TCRE diagnostic compatible with CMIP7 data#702
Draft
schlunma wants to merge 19 commits into
Draft
Conversation
7 tasks
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
|
After adding a series to this diagnostic it seems that one of the regressions tests is not failing even thought the expected series is empty... |
Contributor
|
Can you make an issue to capture that? |
Contributor
Author
|
See #703. |
This was referenced Jun 18, 2026
3 tasks
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bump the transient-climate-response-emissions diagnostic version to 2 because the CMIP7 changes alter results and must trigger recomputation.
Mint the native baseline for the transient-climate-response-emissions CMIP6 test case against ESMValTool 12cb5309 and bump to test_case_version 2. Replay matches the committed bundle. The CMIP7 test case is not minted: its esm-flat10 (flat10MIP) input data is not yet available to fetch.
* origin/main: docs: simplify gate comments and regression docs fix(test-cases): migrate-manifests preserves recorded diagnostic_version fix: backfill diagnostic_version for baselines merged from main docs: rename changelog entry to PR number 770 feat(regression): couple Diagnostic.version into the CI coupling gate feat(example): extract model/reference/bias time series as CMEC series refactor(example): rename diagnostic to global-sst-bias and drop version guard test: close NetCDF datasets in surface-temperature end-to-end tests feat(example): use ocean SST (tos) and add comparison figures test(example): mint regression baselines for surface-temperature-bias fix: address review feedback on surface temperature diagnostic test: update solver regression snapshots for new example diagnostic feat(example): add model-vs-obs surface temperature diagnostic and 5-minute quickstart fix: address review feedback chore: add changelog for config CLI uplift feat: expand config CLI management commands # Conflicts: # packages/climate-ref-esmvaltool/tests/test-data/transient-climate-response-emissions/cmip6/manifest.json
After merging main (diagnostic_version gate + schema 2 backfill), migrate the TCRE baselines to record diagnostic_version 2, matching the in-code Diagnostic.version. CMIP6 replay-matches the committed bundle; CMIP7 has no native baseline yet (its esm-flat10 input data is not available to mint), so the gate selects skip on its committed bundle.
…angelog Drop the four regression artifacts under tests/test-data/regression that were committed by accident; the central Framework-A regression set was removed from main. Add the news fragment for the CMIP7 compatibility work.
Contributor
|
I can't mint a CMIP7 baseline until we have real data to download (esm-flat10 doesn't exist) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #647.
Checklist
Please confirm that this pull request has done the following:
changelog/