[ENG-11457] require at least 1 subject for draft and usual registrations#11786
Merged
brianjgeiger merged 3 commits intoJun 29, 2026
Merged
Conversation
sh-andriy
approved these changes
Jun 26, 2026
sh-andriy
left a comment
sh-andriy
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Validation's in the right spot (register + both set_subjects paths) and the relationship endpoint is replace-only so there's no DELETE bypass. Error maps to a clean 400. Approving.
Collaborator
|
@ihorsokhanexoft Please rebase onto |
ihorsokhanexoft
force-pushed
the
fix/ENG-11457
branch
from
be17693 to
6a623cf
Compare
brianjgeiger
merged commit cb10c39
into
CenterForOpenScience:feature/pbs-26-13
8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-11457
Purpose
Draft registrations and usual registration should have at least 1 subject
Changes
Added validation