fix: Text box doesn't focus on first click - #199
Open
StickmanRed wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The gesture code in
View.Project.jsuses pointer capture to funnel mouse events onto the<canvas>element, which triggers anonclickevent that defocuses the Text tool's text box.This PR implements a hacky fix to avoid breaking the gesture code.
tools/Text.jswraps the canvasonclickhandler in a function that refocuses the text box then sets theonclickhandler to the original handler.Closes #96
Testing
Personally, I like having the text focused in this case.
Not a bug, but a feature lol