Skip to content

WickPM - #197

Open
hobbsythe6th wants to merge 58 commits into
Candlestickers:developmentfrom
hobbsythe6th:wickpm
Open

WickPM#197
hobbsythe6th wants to merge 58 commits into
Candlestickers:developmentfrom
hobbsythe6th:wickpm

Conversation

@hobbsythe6th

Copy link
Copy Markdown
Contributor

WickPM is a package manager class that generates a script tag on the DOM to use to artificially construct esm.sh import statements, which are then attached to WickPM.imports . This PR has attached WickPM, WickPM.imports, and WickPM' s install/uninstall functions to the global API. It's also branched off the Rolldown migration branch of my fork (sorry), but the changed files from that are:
GlobalAPI.js,
WickPM.js,
Wick.mjs (some tiny import updates),
Editor.jsx,
and Project.js .

…e terminal up with annoying deprecation warnings
@InternetAstronaut

Copy link
Copy Markdown

I don't like the way WickPM works. Firstly, the name WickPM is misleading, it doesn't load scripts or objects made for Wick Editor. Secondly, I'm pretty sure you can just do import from scripts.

@hobbsythe6th

Copy link
Copy Markdown
Contributor Author

No, you can't, you get main.381ffc55.js:2 Error: Unexpected token on line 1 in script "default".
at onError (main.381ffc55.js:2:2845680)
at Wick.Project.stop (wickengine.js:51318:47)
at wickengine.js:51234:14
a. @ main.381ffc55.js:2
main.381ffc55.js:2 Error: Unexpected token on line 1 in script "default".
at onError (main.381ffc55.js:2:2845680)
at Wick.Project.stop (wickengine.js:51318:47)
at A_.componentDidUpdate (main.381ffc55.js:2:2845971)
at ca (main.381ffc55.js:2:1372514)
at wl (main.381ffc55.js:2:1390121)
and well you get the idea
from just trying to run import _ from 'https://esm.sh/lodash'; in a script.
As for the name, it just popped into my head before I started so I stuck with it, but I'm open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants