fix(hud): playback ground speed + distinct goals-reached count - #21
Merged
Conversation
- speed: the HUD showed the sim-time speed (~77 m/s), not the pace the viewer sees. Now reported as the on-screen ground speed — frame displacement x frame rate in the video capture, and frame displacement / dt in the live demos (MetricsPublisher.publish(m, dt)). - reached: NavStats.goals_reached counted every per-frame reached flag (so a 4-goal drive read 'reached 6'). Now counts DISTINCT goal indices via a set. Added a test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two HUD-metric fixes flagged on the first-cut overlay:
MetricsPublisher.publish(m, dt)).NavStats.goals_reachedcounted every per-framereachedflag, so a 4-goal drive read "reached 6". Now counts distinct goal indices (set-backedgoals_reachedproperty). Addedtest_goals_reached_counts_distinct_not_per_frame.black + ruff clean; 16 tests pass.