fix: sort.ts/request.tsの表記をunitrad-viewに揃える - #73
Merged
Conversation
ISBN整形の空白表記とrequest.tsのコメントがunitrad-viewから分岐した際に ズレていたため、view側に合わせる。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TBuCdY1AzZrVnRHRXUkLyG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js/sort.tsのISBN整形の空白表記とjs/request.tsのコメントがview側から分岐していたので揃えたsort.ts:207— ISBN整形の空白を実際のU+2002文字3つから、view側と同じ\u2002エスケープ表記のリテラルテキストに変更（見た目の空白は変わらない）request.ts:18-19— コメントの「2600件以上ある」という文言をviewに合わせて追加Note
request.tsの「2600件以上ある」はunitrad-view側の実際のconf件数（2,490件程度）に基づく記述で、unitrad-ui側はconf/が5件のみのため、この数値はunitrad-uiの実態とは一致しない。今回はview側の表記に揃える指示のためそのまま反映しているが、コメントの正確性が気になる場合は別途調整を検討してほしい。Test plan
npm test/npm run typecheckが通ることを確認