Draft: Create pull request template - #11
Conversation
Add a pull request template for asset submissions outlining requirements for original and modified works
|
looks really good could you also include in it where in the repository placeholders.md is? |
|
It doesn't exist yet but I will create and populate one before merging. |
WildWeazel
changed the title
| # Placeholders | ||
| This file lists assets that should be prioritized for replacement. Please keep it up to date and organized as you add or replace assets in this repository. | ||
|
|
||
| ## Low-quality placeholders |
There was a problem hiding this comment.
"Low-quality" is unnecessary here: a placeholder is a placeholder
There was a problem hiding this comment.
True and I didn't care for the phrase myself, but I was trying to distinguish between "the literal name in a box" vs the "everything is a placeholder until we're satisfied" mentality. Another thing that could be elaborated on in the instructions.
There was a problem hiding this comment.
Maybe "Technical placeholders" or "Debug placeholders" or just "Labels"
| @@ -0,0 +1,42 @@ | |||
| # Placeholders | |||
There was a problem hiding this comment.
I'd be keen for this file to be easily machine readable, as it makes scripting (coverage, etc.) easier.
The below structure is fine for this, I think, but maybe the format could be explicitly stated.
There was a problem hiding this comment.
Good idea! It could be yml, which is meant to be easy to hand edit
3 participants
so meta