GAUD-10290 - Fix page content and panel size for short content to avoid unnecessary scroll#7201
Draft
svanherk wants to merge 1 commit into
Draft
GAUD-10290 - Fix page content and panel size for short content to avoid unnecessary scroll#7201svanherk wants to merge 1 commit into
svanherk wants to merge 1 commit into
Conversation
…id unnecessary scroll
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
svanherk
commented
Jul 10, 2026
| .side-nav-panel, | ||
| .supporting-panel { | ||
| height: calc(100vh - var(--d2l-page-header-height, 0) - var(--d2l-page-footer-height, 0)); | ||
| max-height: calc(100vh - var(--d2l-page-header-height, 0) - var(--d2l-page-footer-height, 0)); |
Contributor
Author
There was a problem hiding this comment.
This fixes the panel being larger than it needed to and causing the scroll.
Comment on lines
+120
to
+122
| .content.has-panels { | ||
| min-height: calc(100vh - var(--d2l-page-header-height-measured, 0px)); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We need to add this to make sure the panels are still large enough that the divider covers the whole viewport for short content. But we don't want this when there are no panels, or we'll break the floating-button footer functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the four vdiff tests I called out here. When content on the page is short, the panels were making it larger than it needed to be and causing an unnecessary scrollbar. So we now give panels a max-height tat only kicks in for long content.
You can see the fixed vdiffs here.