GAUD-10298 - Update d2l-page axe tests to test the entire page and fix landmark errors#7200
Merged
Merged
Conversation
…ng the landmark region error
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
reviewed
Jul 13, 2026
| <div class="${classMap(footerContainerClasses)}" ?hidden="${!this._slotVisibility['footer']}"> | ||
| <div | ||
| role="region" | ||
| aria-label="TO DO" |
Member
There was a problem hiding this comment.
Seems like we landed on "Footer" here?
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dlockhart
approved these changes
Jul 13, 2026
|
🎉 This PR is included in version 3.270.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First commit updates the
axetests to test the whole page. We don't usually want this, but since this isd2l-pagewe do, as it should be fully compliant as the only thing on the page. This then causes this error to show up:Second commit rearranges
d2l-pageto fix that! Is a bit nicer to review with whitespace off.