GAUD-8851 remove text scss by EdwinACL831 · Pull Request #7161 · BrightspaceUI/core

EdwinACL831 · 2026-07-03T20:32:21Z

Jira

I strongly suggest to review this commit by commit to understand the final result in case it doesn't make sense right away

- Creates the input-text-styles.js file - Implements the style function generator - Mimics the text.scss styles based on the input-styles.js

…-styles.js

…y input-text-styles.js

EdwinACL831 · 2026-07-03T20:33:23Z

I thought that would be easier to understand and implement style in BSI, therefore I created this new file with the generator function.

github-actions · 2026-07-03T20:33:54Z

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL	https://live.d2l.dev/prs/BrightspaceUI/core/pr-7161/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

EdwinACL831 · 2026-07-03T20:34:31Z

~~What I did here was basically expose some base-style-generator-functions that I used in the new file input-text-styles.js~~

Functions are not any more exported and only used within the _generateInputTextStyles function, which is the only exposed function to BSI for input texts

EdwinACL831 · 2026-07-03T20:35:45Z

this is a good practice that @dlockhart suggested me last time, and I found it very useful. Here we might see how different (if there is any) the component would look with these generated styles, compared to the sass ones

I will revert these changes in this file. The report results are really good and there is not significant difference

GZolla · 2026-07-03T21:37:45Z

+import { _isValidCssSelector } from '../../helpers/internal/css.js';
+import { getFocusVisibleStyles } from '../../helpers/focus.js';
+
+function _generateInputTextDisabledStyles(selector) {


This shouldn't be needed anymore. If you check the input-styles under the off flag. It has the same styles, meant to override focus-styles when item is disabled. However, the new generated styles adds :not(disabled) to those focus styles so they don't need to be overriden

Thanks for the clarification. That answers my comment below as well.

…hey are already handled by the Input base styles by the :not(:disabled)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This reverts commit b285bca.

EdwinACL831 · 2026-07-09T13:57:36Z

+		before(() => {
+			const style = document.createElement('style');
+			style.id = 'generated-styles';
+			style.textContent = _generateInputTextStyles('.d2l-test-input-text');


For example, here is a similar implementation about how this would be done in BSI as well @GZolla and @dlockhart: We would only need to call the generator function, instead of calling multiple functions there in BSI.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…ction comments since they are not longer public

dlockhart · 2026-07-10T19:24:31Z

+
+		${_generateInputDisabledBaseStyles(selector)}
+
+		${_generatewebkitSearchStyles(selector)}


I don't think we want this here since then it'll show up in inputStyles and it wasn't there before. I think we want to only do it from _generateInputTextStyles.

Uh, please correct me if I am wrong but I think that code also was included in the generated inputStyles.. So what I did just be equivalent to what it was before for that portion of the code

Yep you're right -- I was confused because before your last commit it would have been missing them.

That indicates to me that we're missing a vdiff to cover this case for inputStyles, could you add that in?

Hmm although if it's truly only needed for webkit then our vdiffs being Chrome-only won't help. But if it does something for Chrome then it's worth adding vdiffs I think.

OK, I have added test cases for NON-SASS and SASS, making sure the native X doesn't appear thanks to our -webkit- css rule. Thank you!

…appear

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dlockhart

This is looking good!

d2l-github-release-tokens · 2026-07-14T13:37:48Z

🎉 This PR is included in version 3.271.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Edwin Collazos added 7 commits July 3, 2026 14:15

GAUD-8851: Remove text.scss

40790aa

- Creates the input-text-styles.js file - Implements the style function generator - Mimics the text.scss styles based on the input-styles.js

Implements function to encapsulate similar styles generated

62ae002

Exposes base styles from input-styles.js needed in input-text-styles.js

b7177ee

Updates input-text-styles.js to import and use base styles from input…

ac4a874

…-styles.js

Exposes input base styles and selector delegates in orer to be used b…

0f43fa6

…y input-text-styles.js

Updates input-text-styles.js to use the input base style delegates

b248410

Updates vdiffs to use generated input text styles

b285bca

EdwinACL831 requested a review from a team as a code owner July 3, 2026 20:32

EdwinACL831 commented Jul 3, 2026

View reviewed changes

Comment thread components/inputs/input-text-styles.js Outdated

github-actions Bot mentioned this pull request Jul 3, 2026

Updating vdiff goldens for PR 7161 #7162

Merged

GZolla reviewed Jul 3, 2026

View reviewed changes

Edwin Collazos and others added 4 commits July 6, 2026 09:52

Removes function implementation and usage for disabled styles since t…

248ed70

…hey are already handled by the Input base styles by the :not(:disabled)

Updates selector order to avoid unexpected generated css

a80c5c7

Removes sass vdiff tests

58d11b3

Updating vdiff goldens (#7162)

b8167e9

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dlockhart reviewed Jul 7, 2026

View reviewed changes

Comment thread test/node-imports-test.js Outdated

Adds unit test at node-imports-test-js

1c1c9a4

EdwinACL831 force-pushed the ecollazos/GAUD-8851_remove_text_scss branch from a2f113c to 1c1c9a4 Compare July 7, 2026 13:44

EdwinACL831 requested review from GZolla and dlockhart July 7, 2026 18:19

Edwin Collazos added 3 commits July 8, 2026 15:06

Updates the _rend

45ed434

Merge branch 'main' into ecollazos/GAUD-8851_remove_text_scss

206d18b

Revert "Updates vdiffs to use generated input text styles"

6d10409

This reverts commit b285bca.

github-actions Bot mentioned this pull request Jul 9, 2026

Updating vdiff goldens for PR 7161 #7186

Merged

Updates vdiffs to use generated input text styles

de893ff

EdwinACL831 commented Jul 9, 2026

View reviewed changes

Updating vdiff goldens (#7186)

4ab4e9c

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

github-actions Bot mentioned this pull request Jul 9, 2026

Updating vdiff goldens for PR 7161 #7187

Closed

GAUD-8851: proposed changes (#7193)

3a68f1e

github-actions Bot mentioned this pull request Jul 10, 2026

Updating vdiff goldens for PR 7161 #7195

Closed

dlockhart reviewed Jul 10, 2026

View reviewed changes

Comment thread components/inputs/input-styles.js

EdwinACL831 requested a review from dlockhart July 10, 2026 16:51

Edwin Collazos added 2 commits July 10, 2026 13:02

Merge branch 'main' into ecollazos/GAUD-8851_remove_text_scss

6aca880

Adds a new generator function to crete the webkit styles. Deletes fun…

42d8179

…ction comments since they are not longer public

EdwinACL831 force-pushed the ecollazos/GAUD-8851_remove_text_scss branch from c6a8704 to 42d8179 Compare July 10, 2026 18:17

dlockhart reviewed Jul 10, 2026

View reviewed changes

Edwin Collazos added 2 commits July 13, 2026 13:40

Merge branch 'main' into ecollazos/GAUD-8851_remove_text_scss

57b261e

Adds vdiff tests to make sure the webkit X for search inputs doesn't …

8c0de02

…appear

EdwinACL831 requested a review from dlockhart July 13, 2026 18:59

Merge branch 'main' into ecollazos/GAUD-8851_remove_text_scss

866eb27

github-actions Bot mentioned this pull request Jul 13, 2026

Updating vdiff goldens for PR 7161 #7211

Merged

Updating vdiff goldens (#7211)

69888e6

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

dlockhart approved these changes Jul 14, 2026

View reviewed changes

EdwinACL831 merged commit f7a5d91 into main Jul 14, 2026
11 checks passed

EdwinACL831 deleted the ecollazos/GAUD-8851_remove_text_scss branch July 14, 2026 13:35

d2l-github-release-tokens Bot added the released label Jul 14, 2026


		${_generateInputDisabledBaseStyles(selector)}

		${_generatewebkitSearchStyles(selector)}

Uh oh!

Conversation

EdwinACL831 commented Jul 3, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jira

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 3, 2026

Uh oh!

EdwinACL831 Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

EdwinACL831 Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dlockhart left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

d2l-github-release-tokens Bot commented Jul 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EdwinACL831 commented Jul 3, 2026 •

edited by atlassian Bot

Loading

EdwinACL831 Jul 3, 2026 •

edited

Loading

EdwinACL831 Jul 13, 2026 •

edited

Loading