Let users set a custom conda path for MFA (Windows)#149
Merged
Conversation
MFA shells out to conda, which previously had to be on PATH or in one of a few hardcoded Windows install locations. Users with a non-standard Anaconda/Miniconda install (common on Windows) had no way to point VoxKit at their conda.exe. - Add a "Conda Path" field to the MFA align and train settings dialogs. - _find_conda() now accepts an explicit path and also honors a VOXKIT_CONDA_PATH env var, both taking precedence over auto-detection. - Thread the configured path through the MFA service entry points (run_mfa_align, run_mfa_adapt, ensure_dictionary_downloaded, _ensure_mfa_server_running). - Blank/whitespace settings normalize to None, preserving auto-detection. - Add unit tests for the resolution precedence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MFA shells out to
conda, which previously had to be onPATHor sit in one of a handful of hardcoded Windows install locations (~/miniconda3/Scripts/conda.exe, etc.). Users with a non-standard Anaconda/Miniconda install — common on Windows — had no way to point VoxKit at theirconda.exe, and alignment/training would fail with aconda not founderror.This adds a user-configurable conda path.
Changes
services/mfa.py:_find_conda()now accepts an explicit path and also honors aVOXKIT_CONDA_PATHenvironment variable. Resolution order:VOXKIT_CONDA_PATH, if it existscondaonPATHrun_mfa_align,run_mfa_adapt,ensure_dictionary_downloaded, and_ensure_mfa_server_running.None, so the default behavior is unchanged for existing users.conda not founderror message to mention the new setting and env var.Testing
tests/services/test_mfa.pycovers the_find_condaresolution precedence (explicit path,~expansion, env var, nonexistent-path fallback, PATH fallback).invoke lint-check,invoke format-check,invoke mypy-checkall pass.tests/services+tests/enginespass (42 tests).