Skip to content

hotfix/cms-guard-and-missing-translations - #118

Merged
maxparkergene merged 3 commits into
developfrom
hotfix/cms-guard-and-missing-translations
Jul 9, 2026
Merged

hotfix/cms-guard-and-missing-translations#118
maxparkergene merged 3 commits into
developfrom
hotfix/cms-guard-and-missing-translations

Conversation

@dean-smart

Copy link
Copy Markdown
Contributor

Summary

Harden checkout CMS block loading and complete missing English (US) locale entries used by checkout flows.

Changes

  • Treat missing optional CMS blocks as empty content instead of throwing an unhandled Axios error.
  • Apply the optional CMS block handling to privacy policy, general terms, and withdrawal terms content.
  • Add missing en-US translations for Click & Collect weight thresholds, collection location UI, payment labels, postcode lookup, and day names.
  • Align en-GB password help text indentation.

Testing

  • Ran npm run lint in view/frontend/web/js/checkout.

Notes

  • Missing CMS blocks now log a warning and return {}, so dependent components simply do not render their optional content.
  • Non-404 CMS block loading errors still throw, so real service failures are not hidden.

@dean-smart
dean-smart requested a review from maxparkergene June 18, 2026 10:57
@maxparkergene
maxparkergene merged commit fba6f5e into develop Jul 9, 2026
2 checks passed
@maxparkergene
maxparkergene deleted the hotfix/cms-guard-and-missing-translations branch July 9, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants