Post-Processing Results problem fix - #19
Merged
tomvanmele merged 13 commits intoMay 18, 2026
Merged
Conversation
tomvanmele
approved these changes
May 9, 2026
| # ============================================================================ | ||
|
|
||
| conc: Concrete = Concrete.from_strength_class("C30") | ||
| conc.density = 2000 |
Contributor
There was a problem hiding this comment.
what kind of special concrete is this? :)
| from compas_dem.material import Stone | ||
| from compas_dem.models import BlockModel | ||
|
|
||
| # from compas_dem.analysis.cra import cra_penalty_solve |
Contributor
There was a problem hiding this comment.
if we can avoid commented out parts that would be better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tomvanmele
This pull request refactors and expands the example scripts for DEM (Discrete Element Method) analyses, standardizing the workflow across scripts, improving clarity, and updating material assignments and solver usage. The changes include renaming and reorganizing files, updating material property assignments, switching to a more consistent problem/solver setup, and adding or updating documentation strings. Minor code style improvements and bug fixes are also included.
Major changes by theme:
0. Fixed Post-processing Issue
1. Standardization of Problem Setup and Solver Usage
cra_penalty_solve,rbe_solve) with a consistent workflow using theProblemandSolverclasses across all example scripts. This includes explicit setup of contact models, supports, and material assignments before solving.2. Material Assignment and Properties
Stone,Concrete,LimeStone). This ensures all elements have appropriate material properties before analysis.3. File Organization and Documentation
scripts/DEM_Analysis_Examples/directory, and adds or updates docstrings for improved clarity and usage instructions. New example scripts, such asdem_stack.py, are also introduced.4. Solver Parameter Updates
5. Minor Bug Fixes and Code Style Improvements
viewer.setup()withviewer.add_solution())