Fixed an issue when reaching timeout in subsample setting double time… - #154
Merged
Merged
Conversation
… elapsed on parent sampler.
3dgiordano
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a small but important adjustment to how sample timing is recorded for embedded timeout error results in the
HTTP2Samplerclass. The change ensures that the sample's start and elapsed time are set consistently with howSampleResult.setStampAndTimeinterprets its parameters.setStampAndTimeso that thestartedAtMstimestamp is used as the sample start time, aligning with the method's contract and improving timing accuracy for timeout error samples inHTTP2Sampler.java.… elapsed on parent sampler.