Feature/doc url demo site#62
Merged
Merged
Conversation
Introduces new "GitHub" and "Documentation" buttons to all example pages and the main index. The "GitHub" button in the sidebar navigates to the main project repository. The "Documentation" button in the main content area of each example links directly to the respective component's `README.md` file. This change enhances discoverability of the project's source code and detailed component documentation, making it easier for users to explore and understand the implementation.
…lector Applies consistent default and interactive styles to the sidebar GitHub button for improved visual feedback. Ensures SVG icons within buttons are correctly aligned. Refines the `aria-hidden` selector to be more specific to toggle components, preventing unintended hiding of other elements.
Closed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 72cc7ee. Configure here.
Activates the `Link` component on all `a.github-button` elements across the main index and example pages. This ensures external link indicators and accessibility enhancements are applied. Includes internal fixes and refinements to the `Link` class's `init` method: - The component now correctly processes its root element if it matches `a[target="_blank"]`. - The icon rendering loop logic is improved to ensure all applicable links are processed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #55
Note
Low Risk
Demo-site and styling changes plus a small Link init fix; the toggle selector change reduces an accidental layout bug from new markup.
Overview
Adds GitHub and per-component Documentation links across the demo site (
index.htmland all example pages), each pointing to the repo or the matchingexamples/*/README.mdon GitHub. Pages now load a favicon, wireLink.init('a.github-button')so new-tab links get accessible treatment, and share new.github-buttonstyles in the sidebar and main content.Linknow treats the init target as a link when it is itselfa[target="_blank"], processes every matching anchor in a loop (continueinstead ofreturnwhen icons are off), so sidebar and doc buttons work when initialized directly.Toggle demo CSS scopes hidden panels to
[id^="toggle-"][aria-hidden="true"]so decorative GitHub SVGs witharia-hidden="true"no longer match the old global rule.Reviewed by Cursor Bugbot for commit 8dcc6bd. Bugbot is set up for automated code reviews on this repo. Configure here.