feat(reports): add author-shares-control report command#85
Open
torbjokv wants to merge 1 commit into
Open
Conversation
- add author-shares-control CLI command reusing shared _run_report helper - add get_all_institutions_report_control with control Accept header - extract _fetch_institutions_report to share polling logic - add tests for scientific index api and reports CLI
LarsV123
reviewed
Jun 16, 2026
| year: int, | ||
| output: str | None, | ||
| report_name: str, | ||
| fetch, |
Contributor
There was a problem hiding this comment.
Should have type annotation. I'm guessing something like this:
from collections.abc import Callable
fetch: Callable[[ApiClient, int], bytes]
LarsV123
requested changes
Jun 16, 2026
LarsV123
left a comment
LarsV123
left a comment
Contributor
There was a problem hiding this comment.
The code looks fine, but what is this report and why do we need it here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
author-shares-controlreport command alongside the existingauthor-sharesreport.author-shares-controlCLI command that fetches the control variant of the all-institutions reportget_all_institutions_report_controlusing theauthor-shares-controlAccept profile header_fetch_institutions_report(polling logic) and_run_report(CLI handling) to avoid duplication between the two report commands--outputoverride)