Version tagging settings - #344
Conversation
|
@vietle-bh just to let you know, I have provided a |
|
@vietle-bh just to let you know, I have provided a |
pawelbaran
left a comment
There was a problem hiding this comment.
Versioning check passing, users are happy, I can only approve 👍
|
@vietle-bh just to let you know, I have provided a |
|
@BHoMBot check ready-to-merge |
|
@vietle-bh to confirm, the following actions are now queued:
There are 300 requests in the queue ahead of you. |
Issues addressed by this PR
Helps close https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/issues/179
This pull request introduces several upgrade methods to the
v93upgrader, focusing on improving the migration of tagging settings objects to newer versions. The main enhancements involve flattening nested settings structures and handling property renames or removals to align with updated object models.New upgrade methods for tagging settings:
UpgradeMEPGlobalTagSettingsto flatten theUseExclusionZonesproperty from the nestedBhomSettingsdictionary to the top level and remove it from the nested dictionary. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradePointTagSettingsto flatten base settings, renameRiserLeaderAngletoOrthogonalLeaderAngle, and removeTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradeCurveTagSettingsto flatten base settings and remove bothKeepTagPlacementPointOnHostandTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])UpgradeAreaTagSettingsto flatten base settings and remove bothRiserLeaderAngleandTagObscuredDisciplineElements. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])Helper method for flattening:
FlattenBaseSettingsmethod to move properties from the nestedBaseSettingsdictionary to the top level, simplifying the upgrade logic for all tagging settings. ([BHoMUpgrades/CustomUpgrades/v93.csR35-R150])Test files
Please see https://github.com/BuroHappoldEngineering/Revit_Tagging_Tool/pull/180
Changelog
Additional comments