Skip to content

Updated Connector Query to fallback to max distance if connector has no Origin, eg Logical Connectors - #1681

Merged
michal-pekacki merged 1 commit into
developfrom
Revit_Toolkit-#1680-ConnectorQueryFix
Jul 31, 2026
Merged

Updated Connector Query to fallback to max distance if connector has no Origin, eg Logical Connectors#1681
michal-pekacki merged 1 commit into
developfrom
Revit_Toolkit-#1680-ConnectorQueryFix

Conversation

@enarhi

@enarhi enarhi commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Issues addressed by this PR

Closes #1680

The method threw an exception if it was called with Logical Connectors. This update places Logical Connectors at the end of the sorted list instead.

Test files

Any Revit File with MEP Systems containing Logical Connectors.

@enarhi
enarhi requested a review from michal-pekacki July 30, 2026 16:50
@enarhi enarhi self-assigned this Jul 30, 2026
@enarhi enarhi added the type:bug Error or unexpected behaviour label Jul 30, 2026

@michal-pekacki michal-pekacki left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the fix for connectors where Origin isn't available 👍

@michal-pekacki

Copy link
Copy Markdown
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci

bhombot-ci Bot commented Jul 31, 2026

Copy link
Copy Markdown

@michal-pekacki to confirm, the following actions are now queued:

  • check ready-to-merge

There are 120 requests in the queue ahead of you.

@michal-pekacki
michal-pekacki merged commit 7f80472 into develop Jul 31, 2026
20 checks passed
@michal-pekacki
michal-pekacki deleted the Revit_Toolkit-#1680-ConnectorQueryFix branch July 31, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Error or unexpected behaviour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MEP Connectors Query method fails for logical connectors

2 participants