Updated Connector Query to fallback to max distance if connector has no Origin, eg Logical Connectors - #1681
Merged
Conversation
michal-pekacki
approved these changes
Jul 31, 2026
michal-pekacki
left a comment
Contributor
There was a problem hiding this comment.
Happy with the fix for connectors where Origin isn't available 👍
Contributor
|
@BHoMBot check ready-to-merge |
|
@michal-pekacki to confirm, the following actions are now queued:
There are 120 requests in the queue ahead of you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #1680
The method threw an exception if it was called with Logical Connectors. This update places Logical Connectors at the end of the sorted list instead.
Test files
Any Revit File with MEP Systems containing Logical Connectors.