Skip to content

Manage positions page #611#627

Open
nahom70 wants to merge 11 commits into
department-portal-basefrom
manage_positions_ADN
Open

Manage positions page #611#627
nahom70 wants to merge 11 commits into
department-portal-basefrom
manage_positions_ADN

Conversation

@nahom70

@nahom70 nahom70 commented Jul 6, 2026

Copy link
Copy Markdown

Fixes issue #644

Changes

  • Created a positions route in the main route.
  • Queried data from positions history to filter the active positions in history and pass to managepositions.html
  • Edited demo data for position history, tweaked the attributes there to match the model.
  • Added managepositions.css where some CSS logic is handled
  • Added managepositions.js where the datatable logic is handled

Testing

  • Worked around the data and UI through inspection
  • Made sure the passed data is displayed by cross-checking on the database.

@nahom70 nahom70 added the draft label Jul 6, 2026
@nahom70
nahom70 requested a review from BrianRamsay July 6, 2026 15:48
@nahom70
nahom70 marked this pull request as draft July 6, 2026 19:58
@nahom70 nahom70 changed the title Manage positions page Manage positions page #611 Jul 8, 2026
Automation and others added 5 commits July 9, 2026 13:29
@munsakad
munsakad requested a review from sheggen July 10, 2026 17:49
@nahom70
nahom70 requested review from MImran2002 and removed request for BrianRamsay and sheggen July 13, 2026 14:41
@nahom70
nahom70 marked this pull request as ready for review July 13, 2026 17:28
@conwelld conwelld self-assigned this Jul 21, 2026
@NYABUTOA NYABUTOA self-assigned this Jul 21, 2026
@conwelld conwelld removed the draft label Jul 21, 2026

positions = Tracy().getPositionsFromDepartment(org, account)
print(positions)
print("THIS IS Dept:", dept)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only leave in print statements when absolutely necessary. This one is not necessary.

@@ -0,0 +1,9 @@
$(document).ready(function () {

@BetterRocket BetterRocket Jul 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't bootstrap handle tables? If possible, that's the better way.

@@ -3,7 +3,12 @@
{% block scripts %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole file has old versions of stuff. Don't include.


{% endblock %}\


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch currently has a merge conflicts and needs to be merged into the department-portal-base and then the conflicts resolved

Comment thread db_test.py Outdated
details = {
"user": "ute_limited",
"password": "REPLACE",
"password": "VB6PlU$WcbDBqZ3m0IDX",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit or push passwords to GitHub

{% block scripts %}
{{super()}}
<script type="text/javascript" src="{{url_for('static', filename='js/departmentPortal.js') }}?u={{lastStaticUpdate}}"></script>
<<<<<<< HEAD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

departmentPortal.html still has unresolved merge conflict markers (<<<<<<< HEAD, =======, >>>>>>>). This will break the template, so those need to be resolved before merge.

href="{{url_for('static', filename ='css/departmentPortal.css')}}?u={{lastStaticUpdate}}">
=======
<link rel="stylesheet" type="text/css" href="/static/css/departmentPortal.css?u={{lastStaticUpdate}}"/>
>>>>>>> 60ada1ecec53be4b8241ba3c3213984376bc73b6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even this need to be removed


<div class="card-footer text-center">
<a href="#" class="btn btn-primary">View Members
>>>>>>> 60ada1ecec53be4b8241ba3c3213984376bc73b6

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

</div>
</section>

<<<<<<< HEAD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

{% endif %}


<!-- <div class="col-sm-4">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this part.

@BhushanSah

Copy link
Copy Markdown
Contributor

Once the conflict markers and credential issue are fixed, I can review the page logic again.

Comment thread database/demo_data.py

},
{
"positionTitle": "Teaching Associate",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken, fix

Comment thread database/demo_data.py
from app.models.allocation import Allocation
from app.models.positionHistory import PositionHistory
from app.models.positionHistory import PositionHistory
# from app.models.ActivePosition import ActivePosition

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants