Skip to content

fixes needed to build VisualNodeSystemTest on Linux#6

Open
biglari wants to merge 1 commit into
Azzinoth:masterfrom
biglari:master
Open

fixes needed to build VisualNodeSystemTest on Linux#6
biglari wants to merge 1 commit into
Azzinoth:masterfrom
biglari:master

Conversation

@biglari

@biglari biglari commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

I wanted to run the tests branch and had various build errors using gcc 14.2 on Linux Mint 22.3, 64-bit. This is an attempt to fix those build errors to be able to build the tests branch on Linux. Another pull request will provide the changes to the tests branch.

Since the Tests build with VISUAL_NODE_SYSTEM_BUILD_EXECUTION_FLOW_NODES enabled, the fixes to get this to build in the tests branch come down to getting the execution flow nodes to build correctly.

The following fixes were made:

  • use cross platform method to set compile definitions in CmakeLists.txt
  • moved BaseArithmeticOperatorNode::PerformOperation specializations out of class, to fix build error
  • moved BaseArithmeticOperatorNode::Execute to cpp file to fix build error "specialization after instantiation"
  • redefinition of variable RecordID in VisualNodeSystem::UnlinkNodeAreas fixed by renaming variable

I updated the MasterBranchCode submodule in the tests branch to newest (673cdaa) and then applied the fixes included in this pull request. I then applied fixes to the tests branch until I got it to build. I ran the tests which completed with following results:


[----------] Global test environment tear-down
[==========] 306 tests from 13 test suites ran. (2275 ms total)
[  PASSED  ] 302 tests.
[  FAILED  ] 4 tests, listed below:
[  FAILED  ] NodeAreaLoadTest.LoadMediumNodeArea
[  FAILED  ] NodeAreaLoadTest.ConnectionOrderingTest
[  FAILED  ] ExecutionFlowNodesTests.LogicalOperators
[  FAILED  ] ExecutionFlowNodesTests.ControlFlow

Since I was not able to run the tests before applying fixes, I am not sure if the failures were caused by my changes to the master branch, the tests branch, or the updating of the submodule to newest.

I am unable to test on MSVC since I do not have a windows system to test on.

use cross platform method to set compile definitions
moved BaseArithmeticOperatorNode::PerformOperation specializations out
of class, to fix build error
moved BaseArithmeticOperatorNode::Execute to cpp file to fix build error
"specialization after instantiation"
redefinition of RecordID in VisualNodeSystem fixed by renaming variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant