Migrate perf-eval/cni-benchmark/cni-ab-testing pipeline to v2 KCL - #1292
Open
Lei Yao (wonderyl) wants to merge 1 commit into
Open
Migrate perf-eval/cni-benchmark/cni-ab-testing pipeline to v2 KCL#1292Lei Yao (wonderyl) wants to merge 1 commit into
Lei Yao (wonderyl) wants to merge 1 commit into
Conversation
Automated migration of the v1 `pipelines/perf-eval/CNI Benchmark/cni-ab-testing.yml` pipeline (plus its template + scenario closure) into the v2 KCL layout. Contents: - `kcl/perf-eval/cni-benchmark/cni-ab-testing/pipeline.k` — KCL module. - `kcl/perf-eval/cni-benchmark/cni-ab-testing/pipeline.yaml` — generated YAML. - Vendored clusterloader2 `cri` assets under `assets/python/clusterloader2/` (marked with `UPSTREAM`). - Minor `kcl/lib/steps/azure/az_cli.k` extension and `modules/python/clients/docker_client.py` addition used by the new pipeline. Validated by the automated V1↔V2 agent review (`AgentReviewer`) after 4 rounds: scenario identity, trigger surface, 3-way matrix, A/B default vs stateless CNI differentiator, cluster shape (Azure CNI overlay 10.0.0.0/9, /16 subnet, D16ds_v4 nodes, prompool/userpool0 with correct labels+taints), 14-Ready-nodes assertion, clusterloader2 workload with identical override/execute/collect args + CL2 image pin, cloud_info collection, BYO mode gating, RG teardown with lifecycle tags, and the AWS/EKS baseline via eksctl are all reproduced.
Lei Yao (wonderyl)
requested review from
Liyu Ma (liyu-ma),
Vittoria (vittoriasalim) and
xinWeiWei24
as code owners
August 18, 2026 07:38
|
For reviewers only: reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Automated migration of
pipelines/perf-eval/CNI Benchmark/cni-ab-testing.yml(and its full template + scenario closure) into the v2 KCL pipeline layout.Contents
kcl/perf-eval/cni-benchmark/cni-ab-testing/pipeline.k— new KCL module.kcl/perf-eval/cni-benchmark/cni-ab-testing/pipeline.yaml— generated bykcl run, in sync withpipeline.k.kcl/perf-eval/cni-benchmark/cni-ab-testing/assets/python/clusterloader2/— vendored upstream CL2criassets (marked withUPSTREAM).kcl/lib/steps/azure/az_cli.kand a newmodules/python/clients/docker_client.pyused by the new pipeline.Validated by automated V1↔V2 review
The
AgentReviewerran a rigorous 4-round review against the v1 reference bundle and mapped every AKS-facing v1 behavior onto a v2 mechanism:perf-eval/cni-ab-testing, owner/engine/topology metadata).AKS-Telescope-Airlockpool,0 1-23/4 * * *schedule onmain, Manual OR (Schedule AND main) condition,always: true.n10-p{300,700,1100}-memory,max_pods={30,70,110},operation_timeout={3m,7m,11m},load_type=memory,scrape_kubelets=True,host_network=False, 120-min timeout).azure_swedencentral_defaultbindsDefault-CNIvariable group and forwards$(AKS_CLI_CUSTOM_HEADERS);azure_swedencentral_statelessruns the same cluster shape without them.cri-resource-consume, k8s1.33,--tier standard, azure CNI overlay,--pod-cidr 10.0.0.0/9,--service-cidr 192.168.0.0/16,--dns-service-ip 192.168.0.10, attached tocri-vnet(10.0.0.0/9) /cri-subnet-1(10.0.0.0/16).default3 ×Standard_D16ds_v4Ephemeral withCriticalAddonsOnly;prompool1 ×Standard_D16ds_v4labeledprometheus=true;userpool010 ×Standard_D16ds_v4labeledcri-resource-consume=trueand taintedNoSchedule+NoExecute.override+execute+collectwith identical args,ghcr.io/azure/clusterloader2:v20241016, resource-consumer 1.13,pod_startup_latency_threshold=15s.cloud_infocollected and threaded into every result row.skip_resource_management+ OWNER check).always()with lifecycle tags (owner=aks,creation_date,deletion_due_time,SkipAKSCluster=1,SkipASB_Audit=true), plus EKS teardown viaeksctl.eksctlconfig reproducingaws.tfvars(k8s 1.33, VPC 10.0.0.0/16, m5.4xlarge, 3/1/10 pools, same labels/taints, coredns/vpc-cni/kube-proxy addons).Test plan
kcl run kcl/perf-eval/cni-benchmark/cni-ab-testing/pipeline.k -o /tmp/out.yamland diff against the committedpipeline.yaml.swedencentralto verify AKS creation, CL2 execution, result upload, and teardown.