fix: cancel VMSS rolling upgrades before destroy - #1291
Merged
Conversation
Cancel in-progress VMSS rolling upgrades and back off retries to prevent Azure resource deletion failures.
|
For reviewers only: reply |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure teardown reliability by proactively canceling in-progress VMSS rolling upgrades that can prevent AKS node resource group deletion, and by adding a retry backoff when a rolling upgrade is still detected.
Changes:
- Add a pre-destroy Azure step to cancel VMSS rolling upgrades in AKS node resource groups.
- Add a 300-second backoff before task retry when Terraform logs indicate a rolling upgrade is still in progress.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Lei Yao (wonderyl)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure-initiated VM Agent Rolling Upgrades can reject VMSS updates with OperationNotAllowed, causing AKS node resource group deletion to fail. Cancel them first so Terraform destroy can proceed.