feat(hub/frontdoorbackend,member/serviceexport): [PATCH 08/08] L7 exp…#387
Open
rchincha wants to merge 1 commit into
Open
feat(hub/frontdoorbackend,member/serviceexport): [PATCH 08/08] L7 exp…#387rchincha wants to merge 1 commit into
rchincha wants to merge 1 commit into
Conversation
…ort path + AFD OriginGroup + AFD/ATM coexistence Part 08 of an 8-patch split of Azure#373. Closes the loop: member sensors resolve a Private Link Service ID for L7-marked exports, and the hub reconciler programs an AFD OriginGroup + Origins per eligible export. Hub side: - pkg/controllers/hub/frontdoorbackend/controller.go — reconciles FrontDoorBackend CRs by watching eligible InternalServiceExports (Programmed=True, ExportMode=L7-FrontDoor, PLS ID present) and programming one AFD OriginGroup with one Origin per member cluster. - AFD/ATM coexistence guard: if a Service is already exported through ATM (TrafficManagerBackend), FrontDoorBackend is refused with reason=Conflict so a Service cannot be double-exported. - pkg/controllers/hub/frontdoorbackend/{suite_test,controller_integration_test}.go — envtest suite covering happy path (2 eligible exports), pending parent profile, and deletion cleanup. Member side: - pkg/controllers/member/serviceexport/controller.go — adds L7 dispatch: when the Service is annotated with export-mode=L7-FrontDoor, resolve the Private Link Service ARM ID via cloud-provider-azure annotations and stamp it on the InternalServiceExport projection. - pkg/controllers/member/serviceexport/util.go — PLS lookup helper. - pkg/controllers/member/serviceexport/{controller_test,controller_integration_test,suite_test}.go — cover valid PLS annotations, invalid ExportMode, and PLS pending. - cmd/member-net-controller-manager/main.go — inject the PLS client into the serviceexport reconciler. Fakes: - test/common/azurefrontdoor/fakeprovider/{origin,origingroup}.go — in-memory armcdn fakes for origin groups and origins. Depends on all prior patches (01-07). Reconcilers registered against the manager created in PATCH 05. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ort path + AFD OriginGroup + AFD/ATM coexistence
Part 08 of an 8-patch split of #373. Closes the loop: member sensors resolve a Private Link Service ID for L7-marked exports, and the hub reconciler programs an AFD OriginGroup + Origins per eligible export.
Hub side:
Member side:
Fakes:
Depends on all prior patches (01-07). Reconcilers registered against the manager created in PATCH 05.
Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer