feat(hub/frontdoorprofile): [PATCH 06/08] reconciler + WAF/Compliance…#385
Open
rchincha wants to merge 1 commit into
Open
feat(hub/frontdoorprofile): [PATCH 06/08] reconciler + WAF/Compliance…#385rchincha wants to merge 1 commit into
rchincha wants to merge 1 commit into
Conversation
…Mode enforcement + envtest Part 06 of an 8-patch split of Azure#373. First AFD reconciler: FrontDoorProfile. - pkg/controllers/hub/frontdoorprofile/controller.go — reconciles FrontDoorProfile CRs into Azure AFD Premium profiles. - pkg/controllers/hub/frontdoorprofile/waf.go — enforces WAFPolicyRef and ComplianceMode by attaching a SecurityPolicy to the profile. ComplianceMode=SFI-NS253 requires WAFPolicy to be set (validated at admission + reconcile time). Standard_AzureFrontDoor SKU rejected. - pkg/controllers/hub/frontdoorprofile/suite_test.go + controller_integration_test.go — envtest suite covering: * Programmed happy path * WAF not found -> Programmed=False with reason * SFI-Detection mode with unrelated policy - test/common/azurefrontdoor/fakeprovider/{profile,securitypolicy,wafpolicy}.go — in-memory armcdn fakes used by the envtest suite. Depends on API types from PATCH 03 and SDK client bundle from PATCH 04. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Mode enforcement + envtest
Part 06 of an 8-patch split of #373. First AFD reconciler: FrontDoorProfile.
Depends on API types from PATCH 03 and SDK client bundle from PATCH 04.
Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer