build(hub-afd): [PATCH 05/08] hub-afd-controller-manager binary + Hel…#384
Open
rchincha wants to merge 1 commit into
Open
build(hub-afd): [PATCH 05/08] hub-afd-controller-manager binary + Hel…#384rchincha wants to merge 1 commit into
rchincha wants to merge 1 commit into
Conversation
…m chart + Dockerfile Part 05 of an 8-patch split of Azure#373. Introduces the sibling binary that hosts the AFD reconcilers, along with its container image build, Helm chart, and Makefile targets. - cmd/hub-afd-controller-manager/main.go — entry point for the AFD binary. Runs under its own Workload-Identity federated subject so ATM-only tenants do not inherit AFD write permissions (SFI-NS253, docs/first-party/001 §7). - cmd/hub-net-controller-manager/main.go — no longer registers AFD reconcilers (they moved to the new binary). - charts/hub-afd-controller-manager/** — new Helm chart sibling to hub-net-controller-manager (Deployment, RBAC, PDB, values). - docker/hub-afd-controller-manager.Dockerfile — image build recipe. - Makefile — adds hub-afd-controller-manager targets (build, image, push) mirroring the hub-net targets. The AFD reconcilers themselves land in PATCH 06/07/08 and are registered against the manager set up here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…m chart + Dockerfile
Part 05 of an 8-patch split of #373. Introduces the sibling binary that hosts the AFD reconcilers, along with its container image build, Helm chart, and Makefile targets.
The AFD reconcilers themselves land in PATCH 06/07/08 and are registered against the manager set up here.
Copilot-Session: a8fabc68-e113-49ef-b82d-d99a8502da11
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
make reviewablefor basic local testHow has this code been tested
Special notes for your reviewer