Temp/validate mindependency fix#48120
Open
pranz1996 wants to merge 10 commits into
Open
Conversation
Adds ServiceBus unit tests mirroring the EventHub coverage for the pyamqp transport socket-option fix, closing the gap flagged in the PR review. Covers _get_tcp_socket_defaults() and _set_socket_options() for both sync and async transports, verifying defaults are applied and platform-unsupported options (e.g. TCP_MAXSEG) are skipped -- the container/virtualized-environment regression. Refs: Azure#45394
Add unreleased CHANGELOG entries for azure-servicebus and azure-eventhub documenting the pyamqp transport container/virtualized-environment socket-option fix. Refs: Azure#45394
# Conflicts: # sdk/servicebus/azure-servicebus/CHANGELOG.md
Aligns azure-eventhub _version.py with the '## 5.15.2 (Unreleased)' CHANGELOG heading so changelog verification validates against the correct unreleased entry. Refs: Azure#45394
…I consistency check
Validation branch: kseth/fix-transports + mindependency CFSClean fix. Ensures PyPIClient uses the internal Azure Artifacts feed instead of pypi.org during min/latest dependency resolution, which is blocked under CFSClean.
pranz1996
requested review from
EldertGrootenboer,
SwayGom,
axisc,
danieljurek,
hmlam,
j7nw4r,
sagar0207,
sjkwak and
skarri-microsoft
as code owners
July 17, 2026 21:24
|
Azure Pipelines: Successfully started running 1 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates dependency resolution for isolated CI and fixes vendored AMQP socket configuration in Event Hubs and Service Bus.
Changes:
- Defaults dependency resolution to the CFS feed.
- Applies only configured, platform-supported TCP defaults.
- Adds regression tests, release notes, versioning, and Event Hubs API snapshots.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/servicebus/azure-servicebus/tests/unittests/test_transport.py |
Tests socket defaults and application. |
sdk/servicebus/azure-servicebus/CHANGELOG.md |
Documents the connection fix. |
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/utils.py |
Applies formatting. |
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/aio/_transport_async.py |
Filters async socket defaults. |
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/_transport.py |
Filters sync socket defaults and fixes names. |
sdk/servicebus/azure-servicebus/azure/servicebus/_pyamqp/_platform.py |
Restricts platform-safe TCP options. |
sdk/eventhub/azure-eventhub/tests/pyamqp_tests/unittest/test_transport.py |
Tests socket defaults and application. |
sdk/eventhub/azure-eventhub/CHANGELOG.md |
Adds 5.15.2 release notes. |
sdk/eventhub/azure-eventhub/azure/eventhub/_version.py |
Bumps version to 5.15.2. |
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_transport_async.py |
Applies filtered async defaults. |
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_client_async.py |
Applies formatting. |
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py |
Filters sync socket defaults and fixes names. |
sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_platform.py |
Restricts platform-safe TCP options. |
sdk/eventhub/azure-eventhub/api.metadata.yml |
Adds API snapshot metadata. |
sdk/eventhub/azure-eventhub/api.md |
Adds the public API snapshot. |
eng/tools/azure-sdk-tools/ci_tools/scenario/dependency_resolution.py |
Selects CFS for dependency resolution. |
Comment on lines
+48
to
+53
| current = os.environ.get("PIP_INDEX_URL", "") | ||
| if "pkgs.dev.azure.com" in current: | ||
| return | ||
| if current: | ||
| logger.info("Overriding PIP_INDEX_URL %s with CFS feed for dependency resolution.", current) | ||
| os.environ["PIP_INDEX_URL"] = CFS_INDEX_URL |
| if "pkgs.dev.azure.com" in current: | ||
| return | ||
| if current: | ||
| logger.info("Overriding PIP_INDEX_URL %s with CFS feed for dependency resolution.", current) |
…n resolve_compatible_package Under CFSClean, project_release() hits pypi.org and fails. Catch the connection error and continue the best-effort version walk instead of crashing the whole mindependency check.
Comment on lines
+48
to
+50
| current = os.environ.get("PIP_INDEX_URL", "") | ||
| if "pkgs.dev.azure.com" in current: | ||
| return |
| if "pkgs.dev.azure.com" in current: | ||
| return | ||
| if current: | ||
| logger.info("Overriding PIP_INDEX_URL %s with CFS feed for dependency resolution.", current) |
Comment on lines
+752
to
+756
| try: | ||
| version_release = pypi.project_release(package_name, version).get("info", {}).get("requires_dist", []) | ||
| except Exception as e: | ||
| logging.warning( | ||
| "Unable to retrieve release metadata for %s==%s while resolving a compatible version: %s", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines