Add CodeQL native C build scanning to storage pipeline#48098
Open
danieljurek wants to merge 4 commits into
Open
Add CodeQL native C build scanning to storage pipeline#48098danieljurek wants to merge 4 commits into
danieljurek wants to merge 4 commits into
Conversation
danieljurek
requested review from
benbp,
mikeharder,
msyyc and
xirzec
as code owners
July 16, 2026 18:45
|
Azure Pipelines: 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds compiled CodeQL scanning for the storage pipeline and ensures hybrid extension packages use cibuildwheel.
Changes:
- Wires a compiled-CodeQL pipeline parameter through shared templates.
- Detects setup.py-defined extensions alongside pyproject.toml.
- Routes compiled pyproject packages through cibuildwheel.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/storage/ci.yml |
Enables compiled CodeQL for storage. |
eng/pipelines/templates/stages/archetype-sdk-client.yml |
Forwards the CodeQL parameter. |
eng/pipelines/templates/stages/1es-redirect.yml |
Configures compiled C/C++ scanning. |
eng/tools/azure-sdk-tools/ci_tools/parsing/parse_functions.py |
Detects setup.py extensions for pyproject packages. |
eng/tools/azure-sdk-tools/ci_tools/build.py |
Builds detected extensions with cibuildwheel. |
| # checkout happens after the injected "CodeQL Initialize" step | ||
| language: cpp | ||
| compiled: | ||
| enabled: true |
| if enable_wheel and setup_parsed.ext_modules: | ||
| # Use cibuildwheel for compiled extensions (respects [tool.cibuildwheel] config) | ||
| run_logged( | ||
| [sys.executable, "-vv", "-m", "cibuildwheel", "--output-dir", dist], |
Comment on lines
+42
to
+43
| # Enable Compiled CodeQL becuase azure-storage-extensions has C code that | ||
| # must be scanned |
Comment on lines
+713
to
+717
| if not ext_modules: | ||
| sibling_setup_py = os.path.join(package_directory, "setup.py") | ||
| if os.path.exists(sibling_setup_py): | ||
| try: | ||
| setup_py_result = parse_setup_py(sibling_setup_py) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.